-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EmbeddedAnsible] Fix stdout sanitization #1594
[EmbeddedAnsible] Fix stdout sanitization #1594
Conversation
Since the API is now passing the full html source (for the moment) don't sanitize the HTML passed back from the API to retain it's formatting.
@NickLaMuro Cannot apply the following label because they are not recognized: embedded ansible |
Checked commit NickLaMuro@439b310 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
LGTM @NickLaMuro , thanks! Matches what ui-classic does in ansible-raw-stdout. (Except SUI is now asking the orchestration stack for stdout, instead of the task that retrieves it, which makes me think this is probably another place where |
@himdel Awesome, glad I didn't bang my head against the wall for this one on Friday for nothing. Thanks for the review! |
…_stdout_sanitize [EmbeddedAnsible] Fix stdout sanitization (cherry picked from commit 938906d) https://bugzilla.redhat.com/show_bug.cgi?id=1753721
Ivanchuk backport details:
|
Second half of this PR ManageIQ/manageiq#19320
Since the API is now passing the full html source (for the moment), don't sanitize the HTML passed back from the API to retain it's formatting.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1753721
Before
After