Added custom buttons to VM details page #750

chalettu · 2017-05-09T21:04:55Z

PV https://www.pivotaltracker.com/story/show/142774757
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1450473

chalettu · 2017-05-09T21:06:57Z

@miq-bot add_label fine/no
@miq-bot add_label my services / details
@miq-bot add_label enhancement

chalettu · 2017-05-09T21:07:45Z

Screen shot of an example of custom buttons on VM Details page

miq-bot · 2017-05-09T21:18:04Z

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/f2569a62ae850128a352bc41f07daaec61a1cec1~...f2c6f137c530b15b2acee92ce95906b64e4e8fed with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

chriskacerguis · 2017-05-09T21:36:50Z

@ManageIQ/core-ux for your review.

serenamarie125 · 2017-05-10T03:37:00Z

@chalettu the mock is showing custom button and button groups without icons, which looks great! Does the code support displaying an icon if there is one as well?

@chriskacerguis do we have a separate issue or PV for adding custom buttons for VMs on the service details page?

chriskacerguis · 2017-05-10T11:32:52Z

@serenamarie125 yes, there is a separate PT for that (and the custom icons)

Custom images: https://www.pivotaltracker.com/story/show/143798905

Service details: https://www.pivotaltracker.com/story/show/142773333

[edit]: added links

AllenBW · 2017-05-10T14:04:13Z

client/app/services/vms.service.js

@@ -46,6 +46,8 @@ export function VmsService(CollectionsApi, RBAC) {
        'compliances',
        'cpu_affinity',
        'created_on',
+        'custom_actions',


I belieeeeeeve adding these new attributes will break mock api get requests... probably should update that 😬

Yeah, they will. I have an update for mock api that I will submit that should fix these

AllenBW

👍

Loicavenel · 2017-05-12T18:05:27Z

@serenamarie125 can you approve it quickly, thanks

Added custom buttons to VM details page (cherry picked from commit 4918c1a) https://bugzilla.redhat.com/show_bug.cgi?id=1450502

simaishi · 2017-05-12T20:00:28Z

Fine backport details:

$ git log -1
commit 223c3c1425aa5c4945005764fa4349cba08742fc
Author: Chris Kacerguis <[email protected]>
Date:   Fri May 12 13:56:11 2017 -0500

    Merge pull request #750 from chalettu/vm-custom-buttons
    
    Added custom buttons to VM details page
    (cherry picked from commit 4918c1ac4444398983b63540adebb9c03bc94ad9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1450502

simaishi · 2017-05-12T20:11:06Z

@chalettu @chriskacerguis please take a look at Travis failure for fine branch: https://travis-ci.org/ManageIQ/manageiq-ui-service/jobs/231694009.

ERROR in ./client/app/services/vm-details/vm-details.component.js
/home/travis/build/ManageIQ/manageiq-ui-service/client/app/services/vm-details/vm-details.component.js
  102:12  error  'lodash' is not defined  no-undef

chalettu · 2017-05-15T14:35:50Z

Not sure what do on this one @chriskacerguis. I double checked the code and we are defining lodash. This seems like something going wrong with Travis.

chriskacerguis · 2017-05-15T14:37:01Z

I restarted the job...let's see what we see

simaishi · 2017-05-15T14:49:53Z

yarn command failed trying to compile SUI, so I don't think it's Travis... master branch has more change in that file which doesn't exist in fine. Does this PR depend on something that's not in Fine branch?

chriskacerguis · 2017-05-15T14:53:56Z

No. Basically, it's saying it can't find lodash but, it is installed, and injected...so not sure the issue.

chalettu · 2017-05-15T14:53:56Z

Figured it out. Its missing one small thing in that file that probably due to some other changes for vm details not being in fine. @simaishi how do you want me to go about fixing it?

simaishi · 2017-05-15T14:54:58Z

Can you please create a Fine PR, referencing this?

simaishi · 2017-05-18T15:07:58Z

Depends on: ManageIQ/manageiq#14817

Added custom buttons to VM details page

f2569a6

miq-bot added fine/no enhancement labels May 9, 2017

fixed missing line break

f2c6f13

chriskacerguis self-assigned this May 9, 2017

chriskacerguis requested review from AllenBW and serenamarie125 May 9, 2017 21:36

chriskacerguis added the ux/review label May 9, 2017

AllenBW reviewed May 10, 2017

View reviewed changes

AllenBW approved these changes May 10, 2017

View reviewed changes

serenamarie125 approved these changes May 12, 2017

View reviewed changes

chriskacerguis added fine/yes blocker and removed fine/no labels May 12, 2017

chriskacerguis added this to the Sprint 61 Ending May 22, 2017 milestone May 12, 2017

chriskacerguis merged commit 4918c1a into ManageIQ:master May 12, 2017

simaishi pushed a commit that referenced this pull request May 12, 2017

Merge pull request #750 from chalettu/vm-custom-buttons

223c3c1

Added custom buttons to VM details page (cherry picked from commit 4918c1a) https://bugzilla.redhat.com/show_bug.cgi?id=1450502

simaishi added fine/backported and removed fine/yes labels May 12, 2017

chalettu mentioned this pull request May 15, 2017

[FINE] Added lodash to dependencies #764

Merged

chriskacerguis added ux/approved and removed ux/review labels May 17, 2017

chalettu deleted the vm-custom-buttons branch January 10, 2018 19:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added custom buttons to VM details page #750

Added custom buttons to VM details page #750

chalettu commented May 9, 2017 •

edited by simaishi

Loading

chalettu commented May 9, 2017

chalettu commented May 9, 2017

miq-bot commented May 9, 2017

chriskacerguis commented May 9, 2017

serenamarie125 commented May 10, 2017

chriskacerguis commented May 10, 2017 •

edited

Loading

AllenBW May 10, 2017

chalettu May 10, 2017

AllenBW May 10, 2017

AllenBW left a comment

Loicavenel commented May 12, 2017

simaishi commented May 12, 2017

simaishi commented May 12, 2017

chalettu commented May 15, 2017

chriskacerguis commented May 15, 2017

simaishi commented May 15, 2017 •

edited

Loading

chriskacerguis commented May 15, 2017

chalettu commented May 15, 2017

simaishi commented May 15, 2017

simaishi commented May 18, 2017

Added custom buttons to VM details page #750

Added custom buttons to VM details page #750

Conversation

chalettu commented May 9, 2017 • edited by simaishi Loading

chalettu commented May 9, 2017

chalettu commented May 9, 2017

miq-bot commented May 9, 2017

chriskacerguis commented May 9, 2017

serenamarie125 commented May 10, 2017

chriskacerguis commented May 10, 2017 • edited Loading

AllenBW May 10, 2017

Choose a reason for hiding this comment

chalettu May 10, 2017

Choose a reason for hiding this comment

AllenBW May 10, 2017

Choose a reason for hiding this comment

AllenBW left a comment

Choose a reason for hiding this comment

Loicavenel commented May 12, 2017

simaishi commented May 12, 2017

simaishi commented May 12, 2017

chalettu commented May 15, 2017

chriskacerguis commented May 15, 2017

simaishi commented May 15, 2017 • edited Loading

chriskacerguis commented May 15, 2017

chalettu commented May 15, 2017

simaishi commented May 15, 2017

simaishi commented May 18, 2017

chalettu commented May 9, 2017 •

edited by simaishi

Loading

chriskacerguis commented May 10, 2017 •

edited

Loading

simaishi commented May 15, 2017 •

edited

Loading