Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ 1449362 - Refresh button in a dialog does not show in SUI #752

Merged
merged 1 commit into from
May 11, 2017
Merged

BZ 1449362 - Refresh button in a dialog does not show in SUI #752

merged 1 commit into from
May 11, 2017

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented May 10, 2017 •
edited by simaishi
Loading

@chalettu
Copy link
Contributor Author

@miq-bot add_label bug
@miq-bot add_label catalogs

@chalettu
Copy link
Contributor Author

@miq-bot add_label blocker
@miq-bot add_label fine/yes

@AllenBW AllenBW added this to the Sprint 61 Ending May 22, 2017 milestone May 10, 2017
@AllenBW
Copy link
Member

AllenBW commented May 10, 2017

@chalettu can we get before and after ss?

@chalettu
Copy link
Contributor Author

refresh_button

This is a demo of what it looks like if a field has show refresh button enabled on it.

@miq-bot
Copy link
Member

miq-bot commented May 10, 2017

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/d7bb4da149d9c60a93426fbf16e67ad725e7cd90 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@chriskacerguis chriskacerguis requested a review from AllenBW May 10, 2017 18:51
@chriskacerguis chriskacerguis self-assigned this May 10, 2017
AllenBW
AllenBW approved these changes May 10, 2017
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@chriskacerguis
Copy link
Contributor

bug fix, no UX review needed.

@chriskacerguis chriskacerguis merged commit 615c4cb into ManageIQ:master May 11, 2017
simaishi pushed a commit that referenced this pull request May 11, 2017
@chriskacerguis @simaishi
Merge pull request #752 from chalettu/bz-1449362
fc1ea66 
BZ 1449362 - Refresh button in a dialog does not show in SUI
(cherry picked from commit 615c4cb)

https://bugzilla.redhat.com/show_bug.cgi?id=1450096
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit fc1ea66915cc0749bda7620680952e212be8d9a2
Author: Chris Kacerguis <[email protected]>
Date:   Thu May 11 07:09:01 2017 -0500

    Merge pull request #752 from chalettu/bz-1449362
    
    BZ 1449362 - Refresh button in a dialog does not show in SUI
    (cherry picked from commit 615c4cbfee97eb8e3ca0425c6e21f2a240b7912c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1450096

@chalettu chalettu deleted the bz-1449362 branch January 10, 2018 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenBW AllenBW AllenBW approved these changes

Assignees

@chriskacerguis chriskacerguis

Labels
blocker bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chalettu @AllenBW @miq-bot @chriskacerguis @simaishi