-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BZ#1446408 -filter tooltip overflow #753
BZ#1446408 -filter tooltip overflow #753
Conversation
Checked commit AllenBW@84c19c7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
LGTM. Have you guys already bumped your version of Angular PF? I think it was just released on 5/10th (https://github.com/patternfly/angular-patternfly/releases/tag/v3.24.0) |
Yup, it was bumped as part of this PR. |
@serenamarie125 could you please add your approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution to PF as well
@AllenBW there is a conflict backporting to Fine branch. Please confirm ++<<<<<<< HEAD
+ "angular-patternfly": "3.23.2",
++=======
+ "angular-patternfly": "^3.24.0",
++>>>>>>> af8b601... Merge pull request #753 from AllenBW/BZ/#1446408-filtertooltipoverflow |
@AllenBW so just |
Removed |
https://bugzilla.redhat.com/show_bug.cgi?id=1446408
patternfly/angular-patternfly#456
https://www.pivotaltracker.com/story/show/144523025
Screenshots are in the patternfly pr