Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dupilcate of #775 for master - Ensures ansible service displays vm resources #776

Merged
merged 1 commit into from
May 17, 2017

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented May 17, 2017

Identical to #775 except for master (where as #775 was for fine)

Because this is identical to #775 no ss (they're over there)

apologies for the formatting noise

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1451374

@AllenBW AllenBW added this to the Sprint 61 Ending May 22, 2017 milestone May 17, 2017
@AllenBW AllenBW requested a review from chalettu May 17, 2017 20:18
@miq-bot
Copy link
Member

miq-bot commented May 17, 2017

Checked commit AllenBW@870440b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@chriskacerguis chriskacerguis self-assigned this May 17, 2017
@chriskacerguis
Copy link
Contributor

@chalettu can you please review and add feedback?

@chriskacerguis
Copy link
Contributor

This should be a fine/no

@simaishi
Copy link
Contributor

As per my comment in #775, please still mark the 'master' PR as 'yes' even if you need a separate PR for Fine.

@chriskacerguis
Copy link
Contributor

@simaishi will do!

@chriskacerguis
Copy link
Contributor

UX approved #775, this is the same UX change...going to merge.

@chriskacerguis chriskacerguis merged commit 8ef7b5b into ManageIQ:master May 17, 2017
@simaishi
Copy link
Contributor

Backported to Fine via #775

@AllenBW AllenBW deleted the bz/1451374-ansible-with-vm branch May 18, 2017 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants