Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #149678945] The VM status shows "retired" for all VM's , retired or not #856

Merged
merged 1 commit into from
Jul 31, 2017
Merged

[Fixes #149678945] The VM status shows "retired" for all VM's , retired or not #856

merged 1 commit into from
Jul 31, 2017

Conversation

chalettu
Copy link
Contributor

@miq-bot add_label bug
@miq-bot add_label fine/yes
@miq-bot add_label my services

@chalettu chalettu requested a review from chriskacerguis as a code owner July 27, 2017 17:50
@chriskacerguis chriskacerguis self-assigned this Jul 27, 2017
chriskacerguis
chriskacerguis previously approved these changes Jul 27, 2017
View reviewed changes
@chriskacerguis chriskacerguis requested a review from AllenBW July 27, 2017 17:52
@chriskacerguis chriskacerguis added this to the Sprint 66 Ending Aug 7, 2017 milestone Jul 27, 2017
AllenBW
AllenBW reviewed Jul 27, 2017
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalettu Any way we can get a ss of this in action (retired and non retired service? )

@chriskacerguis
Copy link
Contributor

@chalettu ^

@miq-bot
Copy link
Member

miq-bot commented Jul 28, 2017

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/3f76b53813e0e8845e80854cd49ef2abe7b1659c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@chalettu
Copy link
Contributor Author

retired

Retired.

@chalettu
Copy link
Contributor Author

not_retired

Not retired

@chalettu
Copy link
Contributor Author

@AllenBW , take a look at the SS

AllenBW
AllenBW approved these changes Jul 28, 2017
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalettu thanks for posting! lg2m!

@chriskacerguis chriskacerguis merged commit 066a9a0 into ManageIQ:master Jul 31, 2017
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017 •
edited
Loading

@chalettu Is there a BZ for this? Can you please create if it doesn't exist? Found it.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1474532

@AllenBW AllenBW mentioned this pull request Aug 15, 2017
Merged
simaishi pushed a commit that referenced this pull request Aug 24, 2017
@chriskacerguis @simaishi
Merge pull request #856 from chalettu/retired-vm-status
a6af7c3 
[Fixes #149678945] The VM status shows "retired" for all VM's , retired or not
(cherry picked from commit 066a9a0)

https://bugzilla.redhat.com/show_bug.cgi?id=1484608
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit a6af7c36a87e423beda561169bc7a7cbed0ffbff
Author: Chris Kacerguis <[email protected]>
Date:   Mon Jul 31 11:33:03 2017 -0500

    Merge pull request #856 from chalettu/retired-vm-status
    
    [Fixes #149678945] The VM status shows "retired" for all VM's , retired or not
    (cherry picked from commit 066a9a0ccbba683aaedb31c4c9935111a595a3a2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1484608

@chalettu chalettu deleted the retired-vm-status branch January 10, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskacerguis chriskacerguis chriskacerguis approved these changes

@AllenBW AllenBW AllenBW approved these changes

Assignees

@chriskacerguis chriskacerguis

Labels
bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chalettu @chriskacerguis @miq-bot @simaishi @AllenBW