Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/un-hide throttling settings for CPU limits #911

Closed
mturley opened this issue Mar 18, 2019 · 0 comments · Fixed by #915
Closed

Add/un-hide throttling settings for CPU limits #911

mturley opened this issue Mar 18, 2019 · 0 comments · Fixed by #915
Assignees
@mzazrivec
Labels
bz Issues filed by QE or having a BZ enhancement hammer/yes v1.2

Comments

@mturley
Copy link
Contributor

mturley commented Mar 18, 2019 •
edited
Loading

Originally part of issue #867, and implemented but hidden / commented-out in PR #897, we need to uncomment and merge these two throttling fields this CPU throttling field when the back end support is ready.

Edit: moving the network limit field to a separate issue #940 because we need to merge them at different times.

As part of this, we need to add validation (or normalization) of the fields so invalid values can't be saved to the API. General polish and feedback that we didn't get to in #897 should also be addressed.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1690851
@mzazrivec mzazrivec mentioned this issue Mar 19, 2019
Merged
@mturley mturley changed the title Add/un-hide throttling settings for CPU and network limits Add/un-hide throttling settings for CPU limits Apr 18, 2019
@mturley mturley mentioned this issue Apr 18, 2019
Closed
@mturley mturley added bz Issues filed by QE or having a BZ and removed bugzilla needed labels Apr 18, 2019
mturley added a commit that referenced this issue Apr 18, 2019
@mturley
Merge pull request #915 from mzazrivec/add_validation_to_migration_th…
03106c9 
…rottling_inputs

[#911] Add validation to migration throttling inputs and add CPU throttling field
simaishi pushed a commit that referenced this issue Apr 22, 2019
@mturley @simaishi
Merge pull request #915 from mzazrivec/add_validation_to_migration_th…
ea0aa27 
…rottling_inputs

[#911] Add validation to migration throttling inputs and add CPU throttling field

(cherry picked from commit 03106c9)

https://bugzilla.redhat.com/show_bug.cgi?id=1702085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mzazrivec mzazrivec

Labels
bz Issues filed by QE or having a BZ enhancement hammer/yes v1.2
Projects
None yet
Milestone
No milestone
2 participants
@mturley @mzazrivec