Delete Transformation Mappings feature #356
Conversation
move the icon to the `actions` area
Use OverviewSelector filters to get "Not Started", "Active Plans" and "Plans in Error"
|
@vconzola The second Delete Confirmation modal above shows the affected Plans. Do you think we should also delete these Plans -- since there is no point in keeping the plans around without their transformation mapping? |
| /> | ||
| <Modal |
There was a problem hiding this comment.
would you mind moving this Modal to another stateless functional component? i.e. components/DeleteMappingConfirmationModal ? I think extracting this Modal JSX and relevant logic there in another component would be nice...
Will try to test this out on my side today...
There was a problem hiding this comment.
Created a new stateless functional component - DeleteInfrastructureMappingConfirmationModal and moved all the related logic there that is required to construct the delete message.
|
@AparnaKarve We need to keep the plans so users can go back and see which VMs have been migrated. If users want to then archive the plans they can do that separately. That's the direction I've gotten from Brett and Marco. Your question does bring up an interesting point, however. We need to decide what to display for plans that no longer have an associated mapping. I'll create an issue for this. |
|
(Depends on ManageIQ/manageiq-api#383 (in case this goes to gaprindashvili)) |
call the component from `InfrastructureMappingsList`
| <Icon type="pf" name="add-circle-o" /> | ||
| {__('Create Infrastructure Mapping')} | ||
| </a> | ||
| <div> |
There was a problem hiding this comment.
i think we can just use React.Fragment instead of introducing the additional div ? i.e. just wrap Grid.Col and DeleteInfrastructureMappingConfirmationModal w/ React.Fragment
|
thanks for the updates @AparnaKarve ! looks good...just one other minor nit... @himdel looks like this API was merged... i will update locally and test this first thing tomorrow. |
|
confirmed this works locally. merging. |
Added support for deleting transformation mappings
pf deleteicon added in theactionsarea in the list(shows disabled and enabled delete icons)
Simple delete confirmation dialog for a mapping -
Delete confirmation dialog that shows associated Plans that are not started and/or
associated plans in error -
Fixes #297