Fix tests we missed in PR #897 #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll need to put the same BZ on this one that we do for #897, for the throttling changes, which I can't find at the moment. |
|
Checked commit mturley@0fe65b1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
I'm actually going to go ahead and self-merge this so we don't leave master in the red overnight. |
mturley
added
v1.2
bz
simaishi
pushed a commit
that referenced
this pull request
Apr 5, 2019
Fix tests we missed in PR #897 (cherry picked from commit d462568) https://bugzilla.redhat.com/show_bug.cgi?id=1693746
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1688951
I didn't realize that there were snapshot test failures when I merged #897... Travis CI failed to run on that PR! I should have noticed the lack of a green checkmark there.
I'll investigate what's going on with Travis, but master is broken right now,
@mzazrivec can you merge this one for me when you get a chance?Nevermind, I got anxious and self-merged 👀 sorry I know that's a no-no. I'll avoid it in the future.