Fix call to transformation_log_queue #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit https://github.com/djberg96/manageiq-v2v/commit/1635e0d38604ee291163d56e8b2827a171414f4d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
@djberg96 I confirm it works. The related BZs are: |
djberg96
changed the title
|
@miq-bot add_label transformation bug hammer/yes |
|
@djberg96 Cannot apply the following label because they are not recognized: transformation bug hammer/yes |
|
@miq-bot add_reviewer @fdupont-redhat |
|
@miq-bot add_label transformation, bug, hammer/yes |
|
@djberg96 'fdupont-redhat' is an invalid reviewer, ignoring... |
simaishi
pushed a commit
that referenced
this pull request
Apr 5, 2019
Fix call to transformation_log_queue (cherry picked from commit 2f3137c) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1686045
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ServiceTemplateTransformationPlanTask#transformation_log_queuemethod takes two fixed arguments - a userid and log type - rather than a hash of options. You can see the definition here:https://github.com/ManageIQ/manageiq/blob/master/app/models/service_template_transformation_plan_task.rb#L139
I also added some comments.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1655124
WIP for now until I can confirm that this works as expected.