Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BZ#1701330] Mapping Wizard: filter datastores to only those with storage_domain_type === 'data' #947

Merged
merged 2 commits into from
May 8, 2019
Merged

[BZ#1701330] Mapping Wizard: filter datastores to only those with storage_domain_type === 'data' #947

merged 2 commits into from
May 8, 2019

Conversation

mturley
Copy link
Contributor

@mturley mturley commented May 1, 2019

Fixes #942.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1701330
Target CFME release: 5.10.5

Before:

Screenshot 2019-05-01 16 17 24

After (note the absence of the datastore called "Export"):

Screenshot 2019-05-01 16 57 50

@mturley mturley added bug bz Issues filed by QE or having a BZ changelog/yes v1.2 labels May 1, 2019
@mturley mturley requested a review from mzazrivec May 1, 2019 21:00
@miq-bot
Copy link
Member

miq-bot commented May 2, 2019

Checked commits mturley/manageiq-v2v@f02ff72~...655ca02 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

AparnaKarve
AparnaKarve approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@AparnaKarve AparnaKarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified -- looks good!

@AparnaKarve AparnaKarve merged commit aa6a915 into ManageIQ:master May 8, 2019
@mturley mturley deleted the 942-filter-storages branch May 13, 2019 17:22
@mturley mturley changed the title Mapping Wizard: filter datastores to only those with storage_domain_type === 'data' [BZ#1701330] Mapping Wizard: filter datastores to only those with storage_domain_type === 'data' May 13, 2019
@mturley mturley mentioned this pull request May 13, 2019
Merged
simaishi pushed a commit that referenced this pull request May 20, 2019
@AparnaKarve @simaishi
Merge pull request #947 from mturley/942-filter-storages
698b036 
Mapping Wizard: filter datastores to only those with storage_domain_type === 'data'

(cherry picked from commit aa6a915)

https://bugzilla.redhat.com/show_bug.cgi?id=1711032
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 698b03619577382d926f43146767f75ec4bd08a8
Author: Aparna Karve <[email protected]>
Date:   Wed May 8 11:22:22 2019 -0700

    Merge pull request #947 from mturley/942-filter-storages
    
    Mapping Wizard: filter datastores to only those with storage_domain_type === 'data'
    
    (cherry picked from commit aa6a9156a6d86ef9339637261f168b6615348954)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1711032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AparnaKarve AparnaKarve AparnaKarve approved these changes

@mzazrivec mzazrivec Awaiting requested review from mzazrivec

Assignees
No one assigned
Labels
bug bz Issues filed by QE or having a BZ changelog/yes hammer/backported v1.2 z-stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BZ#1701330] Filter out ISO and Export storage domains for RHV Infra Mapping wizard
4 participants
@mturley @miq-bot @simaishi @AparnaKarve