Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#957] [BZ#1712873] Prevent migration task info popovers with long error messages from being pushed off the screen #962

Merged

Conversation

mturley
Copy link
Contributor

@mturley mturley commented May 23, 2019

Fixes #957.
https://bugzilla.redhat.com/show_bug.cgi?id=1712873

The history of .popover max-width continues...

I set the max-width of these specific task info popovers to a sensible 450px in this PR, which should be wide enough to prevent the first issue and narrow enough to prevent the second one.

Maybe we're done now?

This fix can be tested with the database called long-task-error from my collection, which has a plan "rhv-vddk" containing the long error shown in the screenshots below.

Screens

Popover with the original max-width: 220px from bootstrap:
Screenshot 2019-05-23 17 58 05

Popover with max-width: none:
Screenshot 2019-05-23 17 57 32

Popover with max-width: 450px:
Screenshot 2019-05-23 17 57 46

@mturley mturley added bug bz Issues filed by QE or having a BZ hammer/yes z-stream v1.2 labels May 23, 2019
@mturley mturley requested a review from mzazrivec May 23, 2019 22:37
@mturley mturley changed the title [#957] [BZ#1712806] Prevent migration task info popovers with long error messages from being pushed off the screen [#957] [BZ#1712873] Prevent migration task info popovers with long error messages from being pushed off the screen May 23, 2019
@miq-bot
Copy link
Member

miq-bot commented May 23, 2019

Checked commit mturley@9c259e4 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec merged commit b027796 into ManageIQ:master May 24, 2019
@mturley mturley deleted the 957-plan-details-popover-width-fix branch May 24, 2019 14:33
simaishi pushed a commit that referenced this pull request May 24, 2019
[#957] [BZ#1712873] Prevent migration task info popovers with long error messages from being pushed off the screen

(cherry picked from commit b027796)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1713732
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit b9701aae59a6b8660a6a6637d939fc19a6ef4a91
Author: Milan Zázrivec <[email protected]>
Date:   Fri May 24 10:00:12 2019 +0200

    Merge pull request #962 from mturley/957-plan-details-popover-width-fix
    
    [#957] [BZ#1712873] Prevent migration task info popovers with long error messages from being pushed off the screen
    
    (cherry picked from commit b027796cac45cedf0f8e51e1f7c03b4f48c5bef6)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1713732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BZ#1712873] Migration Plan Details page: info popover runs off the screen when error text is long
4 participants