Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Time Profile Editor to Angular #10524

Merged
merged 20 commits into from
Aug 22, 2016

Conversation

AparnaKarve
Copy link
Contributor

Purpose or Intent

This PR converts the Time Profile Editor to Angular.
It also includes directives that ensure that at least one day and one hour are checked.
Note that checkboxes have been replaced by bootstrap switches as shown in the screenshots below.

Screenshots:

Before:
screen shot 2016-08-16 at 11 27 24 am

After:
screen shot 2016-08-16 at 11 28 13 am

With directives in play:
screen shot 2016-08-16 at 11 30 46 am

@Fryguy
Copy link
Member

Fryguy commented Aug 16, 2016

@AparnaKarve Something is wrong with the bot...please don't react to the rubocop things just yet.

@AparnaKarve
Copy link
Contributor Author

@Fryguy Thanks for the heads-up... I was about to address them.

@dclarizio
Copy link

@AparnaKarve I think we need to always show the detailed options below the All Days and All Hours option. It makes it easier to, for example, turn on all days, then just turn off Sat and Sun if I want the 5 weekdays. This is how it worked before.

In addition, if All is chosen and one of the detail options below is turned off, then All should turn off. Likewise, if I check all of the detailed options, All would turn on.

@AparnaKarve AparnaKarve force-pushed the angular_step_by_step_demo branch from d945606 to 7417262 Compare August 22, 2016 19:03
@miq-bot
Copy link
Member

miq-bot commented Aug 22, 2016

Checked commits AparnaKarve/manageiq@e7fa872~...7417262 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
4 files checked, 48 offenses detected

app/controllers/configuration_controller.rb

app/views/configuration/_timeprofile_form.html.haml

  • ⚠️ - Line 110 - Hash attribute should end with no space before the closing brace
  • ⚠️ - Line 110 - Space inside } detected.
  • ⚠️ - Line 127 - Hash attribute should end with no space before the closing brace
  • ⚠️ - Line 127 - Space inside } detected.
  • ⚠️ - Line 145 - Hash attribute should end with no space before the closing brace
  • ⚠️ - Line 145 - Space inside } detected.
  • ⚠️ - Line 162 - Hash attribute should end with no space before the closing brace
  • ⚠️ - Line 162 - Space inside } detected.
  • ⚠️ - Line 202 - Hash attribute should end with no space before the closing brace
  • ⚠️ - Line 202 - Space inside } detected.
  • ⚠️ - Line 32 - Prefer to_s over string interpolation.
  • ⚠️ - Line 32 - Prefer to_s over string interpolation.
  • ⚠️ - Line 32 - Use hash rockets syntax.
  • ⚠️ - Line 33 - Line is too long. [174/160]
  • ⚠️ - Line 49 - Hash attribute should end with no space before the closing brace
  • ⚠️ - Line 49 - Space inside } detected.
  • ⚠️ - Line 64 - Hash attribute should end with no space before the closing brace
  • ⚠️ - Line 64 - Space inside } detected.
  • ⚠️ - Line 94 - Hash attribute should end with no space before the closing brace
  • ⚠️ - Line 94 - Space inside } detected.

@AparnaKarve
Copy link
Contributor Author

@dclarizio Please retest/review. Thanks.
CI error looks unrelated to the PR changes.

@dclarizio dclarizio merged commit eb1d90c into ManageIQ:master Aug 22, 2016
@dclarizio dclarizio added this to the Sprint 45 Ending Aug 22, 2016 milestone Aug 22, 2016
@dclarizio dclarizio deleted the angular_step_by_step_demo branch August 22, 2016 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants