-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Time Profile Editor to Angular #10524
Convert Time Profile Editor to Angular #10524
Conversation
@AparnaKarve Something is wrong with the bot...please don't react to the rubocop things just yet. |
@Fryguy Thanks for the heads-up... I was about to address them. |
@AparnaKarve I think we need to always show the detailed options below the All Days and All Hours option. It makes it easier to, for example, turn on all days, then just turn off Sat and Sun if I want the 5 weekdays. This is how it worked before. In addition, if All is chosen and one of the detail options below is turned off, then All should turn off. Likewise, if I check all of the detailed options, All would turn on. |
d945606
to
7417262
Compare
Checked commits AparnaKarve/manageiq@e7fa872~...7417262 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/controllers/configuration_controller.rb
app/views/configuration/_timeprofile_form.html.haml
|
@dclarizio Please retest/review. Thanks. |
Purpose or Intent
This PR converts the Time Profile Editor to Angular.
It also includes directives that ensure that at least one day and one hour are checked.
Note that checkboxes have been replaced by bootstrap switches as shown in the screenshots below.
Screenshots:
Before:

After:

With directives in play:
