-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure provision template to restrict VM names #12947
Conversation
I was just looking at this. There are a few other less obvious restrictions like the username can't be "root" or "Administrator" The most common error is an invalid password but MS keeps changing those rules frequently, but maybe the length restriction could be added. Password restrictions |
@jteehan This is just for VM names, not admin names and passwords. That will be a separate PR. |
@miq-bot add_label wip |
Need to look at this some more, it seems to treat valid names as invalid for some reason. |
Turns out it was just a matter of fixing "regexp". |
@miq-bot remove_label wip |
@miq-bot add_label euwe/yes |
@gmcculloug Look alright? |
Update Azure provision template to restrict VM names (cherry picked from commit 5f9094f) https://bugzilla.redhat.com/show_bug.cgi?id=1402528
Euwe backport details:
|
This adds a VM name constraint to the Azure provisioning dialog, restricting it to alphanumeric characters, hyphens and underscores, with a range of 1-15 characters. Some additional restrictions have also been included regarding leading and trailing characters.
Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1377889