Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Containers Dashboard: Support hourly and realtime trends #13112

Closed
wants to merge 1 commit into from

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Dec 12, 2016

In case that there are no daily trends yet, we would like to display hourly trends instead.
Currently added support only in the Network Utilization card, still need to add support in the rest of the dashboard cards.

dashboard

dashmin

@zakiva zakiva changed the title Containers Dashboard: Support hourly trends [WIP] Containers Dashboard: Support hourly trends Dec 12, 2016
@zakiva
Copy link
Contributor Author

zakiva commented Dec 12, 2016

@miq-bot add_label enhancement, providers/containers, ui, wip

@zakiva
Copy link
Contributor Author

zakiva commented Dec 12, 2016

@simon3z @zeari @yaacov Please review

@simon3z
Copy link
Contributor

simon3z commented Dec 12, 2016

In case that there are no daily trends yet, we would like to display hourly trends instead.

@zakiva we wanted also to display realtime in case hourly are not available. Is that possible?

@zakiva zakiva force-pushed the dashboard_hourly_trends branch from d566681 to 9c82355 Compare December 13, 2016 16:26
@zakiva
Copy link
Contributor Author

zakiva commented Dec 13, 2016

@zakiva we wanted also to display realtime in case hourly are not available. Is that possible?

Yes, I have added support for displaying "realtime" data as well.
I was not sure what is the preferred time interval here, so I set it currently to "last 60 minutes", but it can be changed of course.

@zakiva zakiva changed the title [WIP] Containers Dashboard: Support hourly trends [WIP] Containers Dashboard: Support hourly and realtime trends Dec 13, 2016
@zakiva zakiva force-pushed the dashboard_hourly_trends branch from 9c82355 to 6ad1ea8 Compare December 13, 2016 21:54
@miq-bot
Copy link
Member

miq-bot commented Dec 13, 2016

Checked commit zakiva@6ad1ea8 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 1 offense detected

app/services/container_dashboard_service.rb

  • ❕ - Line 190, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for realtime_network_metrics is too high. [27.75/20]

@simon3z
Copy link
Contributor

simon3z commented Dec 13, 2016

@zakiva what is missing to remove all the "wip"s?

@zakiva
Copy link
Contributor Author

zakiva commented Dec 14, 2016

@zakiva what is missing to remove all the "wip"s?

Still need to add this support in the other dashboard cards (unless you prefer to add it in separated PRs?) and handle the tests, will do it next week. Meanwhile, it will be nice to have @zeari and @yaacov review the current changes.

@yaacov
Copy link
Member

yaacov commented Dec 15, 2016

LGTM 👍

p.s.
You can make a helper function like the daily_provider_metrics and remove the AbsSize rubocop error.

@miq-bot
Copy link
Member

miq-bot commented Dec 22, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@zakiva
Copy link
Contributor Author

zakiva commented Dec 25, 2016

Moved to ManageIQ/manageiq-ui-classic#33, closing.

@zakiva zakiva closed this Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants