Don't charge hours before Vm/Container/Project was created #13373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtanzillo
approved these changes
Jan 10, 2017
gtanzillo
reviewed
Jan 10, 2017
| # 2) We cannot charge for future hours (i.e. weekly report on Monday, should charge just monday) | ||
| @consumed_hours_in_interval ||= begin | ||
| consuption_start = [@start_time, resource.try(:created_on)].compact.max | ||
| consumption_end = [Time.current, @end_time].min |
There was a problem hiding this comment.
Should this use Time.current.utc to ensure the time is not in the local time zone?
There was a problem hiding this comment.
I was thinking about this for a while. It seems the TZ does not matter in this case.
The consumption_end is just used for substraction.
|
This pull request is not mergeable. Please rebase and repush. |
We are gonna change code to charge only for consumption since the resource creation time. First, we need to make sure all our test subject have proper created_on timestamp.
isimluk
force-pushed
the
consumption-starttime
branch
from
88d3dc1 to
1317470
Compare
isimluk
changed the title
|
@miq-bot remove_label wip |
|
Checked commits isimluk/manageiq@e2d0561~...1317470 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
Backported to Euwe via #13554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When calculating average consumption (like Mhz) we divide consumption by number of hours in the interval. However, when VM gets created in the middle of the month, we should divide only by number of hours that the resource lived. Similarly, we should charge the consumption only for the hours that the resource existed.
Why
This becomes important for SCVMM. We charge for SCVMM without metric rollups. Hence, this case have higher chances to occur with SCVMM chargebacks. (Although it affects rollup-based chargebacks as well).
Note
This pr builds on top of #13134.
@miq-bot add_label chargeback, bug
@miq-bot assign @gtanzillo