Add description to miq_alert_statuses #13653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @simon3z @jeff-phillips-18 This is called "message" in the mockups |
|
@miq-bot add_label enhancement, wip |
moolitayer
force-pushed
the
add_status_description
branch
2 times, most recently
from
b0688ec to
2fd3d26
Compare
moolitayer
changed the title
moolitayer
force-pushed
the
add_status_description
branch
from
2fd3d26 to
a07ea2d
Compare
simon3z
reviewed
Jan 30, 2017
|
|
||
| result | ||
| end | ||
|
|
||
| def add_status_post_evaluate(target, result) | ||
| def add_status_post_evaluate(target, result, statue_description) |
There was a problem hiding this comment.
@moolitayer typo: statue_description
moolitayer
force-pushed
the
add_status_description
branch
from
a07ea2d to
18453d7
Compare
|
Checked commit moolitayer@18453d7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 db/migrate/20170125141953_update_description_in_miq_alert_status.rb
|
simon3z
reviewed
Jan 30, 2017
| miq_alert_statuses = Arel::Table.new('miq_alert_statuses') | ||
| join_sql = miq_alerts.project(miq_alerts[:description]) | ||
| .where(miq_alerts[:id].eq(miq_alert_statuses[:miq_alert_id])).to_sql | ||
| MiqAlertStatus.update_all("description = (#{join_sql})") |
There was a problem hiding this comment.
Not sure about this one. We need someone to properly review it. Maybe @kbrock
There was a problem hiding this comment.
Heh, I would have done sql instead of areal but it looks good.
update miq_alert_statuses
set description = (
select miq_alerts.description
from miq_alerts
where miq_alerts.id = miq_alert_statuses.miq_alert_id
)LGTM 👍
|
LGTM 👍 @gtanzillo can you check if this is OK for Alerts in general? @miq-bot assign gtanzillo |
This was referenced Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why cookie description from miq_alert to miq_alert_statuses?
We want to support generic alerting from external systems (hawkular).
What we get from it is only instances of an alert (==miq_alert_status) containing a description and there is no entity parallel to miq_alert.
The purpose of this change is to take the description from the MAS when it is available (container alerts from hawkular) or from the MA otherwise (all other providers including middleware alerts)
The piece adding the external description on mas will come in the event collection patch #12773