Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUWE] Backport of manageIq-ui-classic PR#264 - Cascading auto refresh #13779

Merged

Conversation

eclarizio
Copy link
Member

@eclarizio eclarizio commented Feb 6, 2017

All details can be found in ManageIQ/manageiq-ui-classic#264, this is simply a backport of this work, as we believe it will resolve issues encountered in https://bugzilla.redhat.com/show_bug.cgi?id=1411541.

/cc @gmcculloug

Conflicts for Euwe were extremely minor, only issue was in a spec that needed to be passed a new parameter.

@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2017

Checked commit eclarizio@2a8c23f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 4 offenses detected

app/helpers/application_helper/dialogs.rb

app/views/shared/dialogs/_dialog_field.html.haml

  • ⚠️ - Line 16 - Avoid the use of double negation (!!).

spec/helpers/application_helper/dialogs_spec.rb

  • ❗ - Line 493, Col 9 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
  • ❗ - Line 498, Col 7 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@simaishi simaishi merged commit 0160a60 into ManageIQ:euwe Feb 9, 2017
@simaishi simaishi added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants