Add tag to container_label_tag_mapping factory

[agrare]

ContainerLabelTagMapping assumes it belongs_to a tag so add this to the
factory.

Introduced by #16501

[NickLaMuro]

Looks good. Confirmed it gets rid of the undefined method name' for nil:NilClasserror from theFactory`.

[agrare]

cc @Fryguy

[miq-bot]

Checked commit agrare@e0e2cb4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[NickLaMuro]

@agrare can you link to #16501 in the description?

[cben]

Thanks for the fix 🤕
I'm not sure about managed_kubernetes_tag because current implementation expects tag with (1) such name (2) linked to Classification that is read_only — and this only ensures (1). That's what I added tag_mapping_with_category for.

I'm going to look for prettier alternatives but 👍 to merge this first.

@miq-bot add-label gaprindashvili/yes
#16501 is gaprindashvili/backported, and made manageiq-ui-classic red on gaprindashvili too.

[cben]

OK turns out using the new tag_mapping_with_category factory in the UI test fixes it:
ManageIQ/manageiq-ui-classic#2788
What do you think?

UPDATE: that was merged, fixed ui master & gaprindashvili

[agrare]

@cben that looks good, does it make sense to have a base container_label_tag_mapping factory that doesn't have a tag? Should we add just a FactoryGirl.create(:tag) given that anyone using this factory will fail due to not checking if the tag is nil?

[cben]

See discussion on the other PR. This base factory is now only useful if you provide a separately created :tag, and we have tests that do exactly this. I hope to delete some code & rewrite/remove those tests, and will re-evaluate the factories then.

[agrare]

This base factory is now only useful if you provide a separately created
:tag, and we have tests that do exactly this.

Ah okay this is what I was missing.