-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add evm:db:dump:local and evm:db:dump:remote tasks #17483
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bf7e19f
Adds helper method for building calculated db_opts
NickLaMuro 6ad1323
Adds EvmDatabaseOps.with_mount_session (private)
NickLaMuro 594e50d
Add EvmDatabaseOps.validate_free_space
NickLaMuro 93ef4c1
Add EvmDatabaseOps.dump
NickLaMuro cb8524a
Add evm:db:dump:local and evm:db:dump:remote tasks
NickLaMuro 051a1f7
Add --exclude-table-data to evm:db:dump tasks
NickLaMuro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the restore for the dump side of things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this is handled in
PostgresAdmin
:https://github.com/ManageIQ/manageiq-gems-pending/blob/559540c54a32f202a60db14d6ba4a51bf01262e5/lib/gems/pending/util/postgres_admin.rb#L93-L102
Oddly enough, written by you: ManageIQ/manageiq-gems-pending@dbb78da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol sorry, I read this as
task :restore do
🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be more clear, I was suggesting removing this task because I thought it was restoring a pg_dump which I don't really want to do unless it was an old backup (from before we removed it as a backup option).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is fair. Yeah, I really don't plan to support
pg_dump
restores myself. I have a fun set of directions for importing DBs when working on performance issues and such, so me personally, I only really care about getting thepg_dump
stuff working from a "backup" perspective.The fact that it "can work" in the
:restore
tasks is just a nice plus.