Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing add_inventory_collection and has_inventory interfaces #17736

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Removing add_inventory_collection and has_inventory interfaces #17736

merged 2 commits into from
Jul 24, 2018

Conversation

slemrmartin
Copy link
Contributor

Deprecated interfaces add_inventory_collection and has_inventory replaced by add_collection interface

Issue #17396

depends on all PRs in issue

@slemrmartin
Removing add_inventory_collection and has_inventory
a892946 
Deprecated interfaces replaced by add_collection interface
@slemrmartin slemrmartin changed the title Removing add_inventory_collection and has_inventory interfaces [WIP] Removing add_inventory_collection and has_inventory interfaces Jul 20, 2018
@slemrmartin slemrmartin mentioned this pull request Jul 20, 2018
Closed
33 tasks
@miq-bot miq-bot added the wip label Jul 20, 2018
@slemrmartin slemrmartin mentioned this pull request Jul 23, 2018
Merged
1 task
@agrare agrare self-assigned this Jul 23, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2018

Checked commits slemrmartin/manageiq@a892946~...6ca376d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

@slemrmartin slemrmartin changed the title [WIP] Removing add_inventory_collection and has_inventory interfaces Removing add_inventory_collection and has_inventory interfaces Jul 24, 2018
@miq-bot miq-bot removed the wip label Jul 24, 2018
@slemrmartin
Copy link
Contributor Author

cc @agrare @Ladas it seems that refactoring is complete, we can delete old ones

Ladas
Ladas approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooohoooo 🎉 🎉 🥇

@slemrmartin
Copy link
Contributor Author

:))
btw. specs for all influenced providers were successful.

agrare
agrare approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 nice @slemrmartin !

@agrare agrare merged commit d549a31 into ManageIQ:master Jul 24, 2018
@slemrmartin slemrmartin deleted the ic-builder-cleanup branch July 26, 2018 08:13
@agrare agrare added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 31, 2018
@agrare agrare mentioned this pull request Aug 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladas Ladas Ladas approved these changes

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
cleanup providers/inventory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slemrmartin @miq-bot @Ladas @agrare