Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to access graph refresh settings #17916

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 28, 2018

Add some methods to the base manager refresher to access graph refresh
settings instead of the same logic sprinkled around.

Add some methods to the base manager refresher to access graph refresh
settings instead of the same logic sprinkled around.
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@miq-bot
Copy link
Member

miq-bot commented Aug 28, 2018

Checked commit agrare@f5bc9a9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo added this to the Sprint 94 Ending Sept 10, 2018 milestone Aug 28, 2018
@gtanzillo gtanzillo merged commit 5f129ad into ManageIQ:master Aug 28, 2018
@agrare agrare deleted the refactor_refresher_options_graph_refresh_settings branch August 28, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants