InventoryCollection definitions for Lenovo #18063
Conversation
slemrmartin
force-pushed
the
lenovo-graph-refresh
branch
from
a7f1495 to
123c4c3
Compare
slemrmartin
changed the title
| # # Tmp solution with serial_number works for specs | ||
| def canisters | ||
| add_properties(:manager_ref => %i(physical_storage serial_number)) | ||
| add_properties(:manager_ref_allowed_nil => %i(serial_number)) |
There was a problem hiding this comment.
I'm concerned about the serial_number being able to be nil, there is an ems_ref column on canisters can we use physical_storage + ems_ref as the manager_ref and it is up to the lenovo parser to make sure it is present? I don't want to be solving any of the lenovo specific problems in the generic physical infra inventory collections.
There was a problem hiding this comment.
there is no ems_ref (UUID) for canisters in this Lenovo API request. It's the same problem like in old refresh. There should be called /canisters separatedly. But this PR should be as similar as possible as old refresh and another usage of API should be implemented in another PR (..and I have only VCR cassettes where this request isn't available)
| # Tmp solution with serial_number works for specs | ||
| def physical_disks | ||
| add_properties(:manager_ref => %i(physical_storage serial_number)) | ||
| add_properties(:manager_ref_allowed_nil => %i(serial_number)) |
There was a problem hiding this comment.
unfortunatelly this is not the same. Physical disks doesn't have unique identifier, I'll look what they used in recent PR, but I think they used the same column
There was a problem hiding this comment.
@agrare discussion was there: ManageIQ/manageiq-schema#285 (same as for canisters)
slemrmartin
force-pushed
the
lenovo-graph-refresh
branch
from
6332a9b to
afdfba9
Compare
slemrmartin
force-pushed
the
lenovo-graph-refresh
branch
from
afdfba9 to
aaeb608
Compare
|
Checked commit slemrmartin@aaeb608 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
| @@ -48,9 +48,15 @@ def physical_storages | |||
| add_common_default_values | |||
| end | |||
|
|
|||
| def canisters | |||
| def physical_switches | |||
| add_properties(:manager_ref => %i(uid_ems)) | |||
| add_common_default_values | |||
There was a problem hiding this comment.
canisters doesn't have ems_id
Definitions of inventory collections for graph refresh.
dependent: ManageIQ/manageiq-providers-lenovo#236