Handle picture correctly on service template update/create #18674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
changed the title
jrafanie
reviewed
Apr 23, 2019
app/models/service_template.rb
Outdated
| @@ -509,7 +513,10 @@ def resource_action_list | |||
|
|
|||
| def update_from_options(params) | |||
| options[:config_info] = params[:config_info] | |||
| update_attributes!(params.except(:config_info)) | |||
| if params[:picture] | |||
| update_attributes!(:picture => Picture.create(:content => params[:picture][:content], :extension => 'jpg')) | |||
There was a problem hiding this comment.
Do we only support jpg? If not, how do we know the extension?
There was a problem hiding this comment.
ugh, fine, no, to the first: https://github.com/ManageIQ/manageiq/blob/master/app/models/picture.rb#L5 and ugh, fine, i guess it's we assume it's in the params too? maaaaaybe?
There was a problem hiding this comment.
Maybe? I don't know how we create pictures.
|
Looks good, only had a question above. |
d-m-u
force-pushed
the
fix_creating_service_template_with_picture
branch
from
e11a5e5 to
b74de6e
Compare
|
Checked commit d-m-u@b74de6e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
approved these changes
Apr 23, 2019
simaishi
pushed a commit
that referenced
this pull request
Apr 23, 2019
…th_picture Handle picture correctly on service template update/create (cherry picked from commit d26ae5a) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702479
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not creating service templates with pictures correctly (or updating them) because the template is expecting a picture and instead gets a hash of options to create the picture.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1683723