Create multiple requests for multiple service retirement #18958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, hammer/yes |
d-m-u
force-pushed
the
fixing_request_number_creation_for_multiple_services
branch
from
47204e8 to
7532456
Compare
d-m-u
force-pushed
the
fixing_request_number_creation_for_multiple_services
branch
2 times, most recently
from
f129393 to
c9b73d7
Compare
d-m-u
changed the title
|
@bdunne could you please review? |
|
@miq-bot remove_label wip |
bdunne
reviewed
Jul 11, 2019
d-m-u
force-pushed
the
fixing_request_number_creation_for_multiple_services
branch
from
c9b73d7 to
da51988
Compare
d-m-u
commented
Jul 11, 2019
| else | ||
| req_obj.source.name | ||
| end | ||
|
|
||
| new_settings = [] | ||
| "#{request_class::TASK_DESCRIPTION} for: #{name} - #{new_settings.join(", ")}" |
There was a problem hiding this comment.
There are never any new_settings for a retirement task so this is superfluous. Provisioning holdover that was left in, mea culpa.
d-m-u
force-pushed
the
fixing_request_number_creation_for_multiple_services
branch
2 times, most recently
from
80d76df to
9890c1d
Compare
d-m-u
force-pushed
the
fixing_request_number_creation_for_multiple_services
branch
from
9890c1d to
2d718e2
Compare
|
Checked commit d-m-u@2d718e2 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
If Brandon doesn't complain about the fact that there's one commit for a couple different things going on here, this should at least partially fix https://bugzilla.redhat.com/show_bug.cgi?id=1721501 |
simaishi
pushed a commit
that referenced
this pull request
Jul 22, 2019
…or_multiple_services Create multiple requests for multiple service retirement (cherry picked from commit 42a55cc) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1723833
|
Hammer backport details: |
d-m-u
deleted the
fixing_request_number_creation_for_multiple_services
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1722194
We should be creating multiple requests for when you hit retire_now for multiple services. Thus the description with multiple services on one request should never get used and can get ✂️