introduce clusterless hosts as an association #20047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
reviewed
Apr 3, 2020
| hosts = FactoryBot.create_list(:host, 2, :ext_management_system => ems) | ||
| FactoryBot.create_list(:host, 2, :ext_management_system => ems, :ems_cluster => cluster) | ||
|
|
||
| expect(ems.clusterless_hosts).to match_array(hosts) |
There was a problem hiding this comment.
How about 1 host with a cluster and 1 clusterless host and assert only the latter is returned?
There was a problem hiding this comment.
Keenan pointed me at line 34 where it's creating a clustered host so we can be sure it's only returning the non-clustered hosts and not the clustered ones. 👍
kbrock
force-pushed
the
infra_clusterless_hosts
branch
3 times, most recently
from
f1eb50e to
0eced14
Compare
kbrock
force-pushed
the
infra_clusterless_hosts
branch
from
0eced14 to
b0dc064
Compare
|
Checked commit kbrock@b0dc064 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
Note, rails 5.1 seems to have just discarded bogus associations when you call preload but 5.2 is very picky and complains. |
simaishi
pushed a commit
that referenced
this pull request
Apr 16, 2020
introduce clusterless hosts as an association (cherry picked from commit 7320484)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing an issue when the association was references (but it wasn't really an association)