database_connectivity? should handle not-running database #21064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLaMuro
reviewed
Feb 18, 2021
chessbyte
reviewed
Feb 18, 2021
Fryguy
force-pushed
the
fix_database_source2
branch
from
7f4a203 to
98aef4d
Compare
chessbyte
approved these changes
Feb 18, 2021
To reproduce, disable your local postgres instance and run `bundle exec rake test:verify_no_db_access_loading_rails_environment` Follow up to 76731ae
Fryguy
force-pushed
the
fix_database_source2
branch
from
98aef4d to
72f25df
Compare
|
Checked commit Fryguy@72f25df with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
agrare
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce, disable your local postgres instance and run
bundle exec rake test:verify_no_db_access_loading_rails_environmentFollow up to 76731ae (#21038)
In the original pass, we didn't handle when the database just isn't running at all, which raises a different exception. As such, this is blocking builds, because they are blowing up trying to check if the database is connectable or not.
@NickLaMuro Please review.
cc @simaishi @agrare