Fix Marshal.load ArgumentError on ruby3.3 #23219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed / open after merge of #23220 |
``` config/initializers/marshal_autoloader.rb:6:in `load': wrong number of arguments (given 2, expected 1) (ArgumentError) from /usr/lib/ruby/3.3.0/rdoc/store.rb:974:in `block in marshal_load' from /usr/lib/ruby/3.3.0/rdoc/store.rb:974:in `open' ```
agrare
force-pushed
the
fix_marshal_load_argument_error_tab_complete_ruby_3_3
branch
from
9368320 to
abc8013
Compare
jrafanie
reviewed
Oct 2, 2024
| @@ -3,7 +3,7 @@ | |||
| # processes or load just the classes that are marshaled, which may be far less classes and locations than when | |||
| # we originally wrote this initializer. | |||
| module MarshalAutoloader | |||
| def load(data) | |||
| def load(data, _proc = nil) | |||
There was a problem hiding this comment.
haha, I was just about to comment to add that = nil!
Great minds think alike.
|
Checked commit agrare@abc8013 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
jrafanie
approved these changes
Oct 2, 2024
agrare
deleted the
fix_marshal_load_argument_error_tab_complete_ruby_3_3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this using tab-complete in a rails console on ruby 3.3. It appears that rdoc is passing a proc to Marshal.load and that is causing our initializer monkeypatch to fail.