[WIP] Rails71 #23225
Open
[WIP] Rails71 #23225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
rails71
branch
2 times, most recently
from
8888823 to
35c7f80
Compare
1 task
jrafanie
force-pushed
the
rails71
branch
2 times, most recently
from
95c915c to
728da06
Compare
This was referenced Oct 30, 2024
This was referenced Nov 1, 2024
jrafanie
force-pushed
the
rails71
branch
2 times, most recently
from
0eb4c64 to
ea2d65d
Compare
jrafanie
force-pushed
the
rails71
branch
2 times, most recently
from
833bd39 to
ae95f19
Compare
jrafanie
commented
Jan 30, 2025
| @@ -4,6 +4,7 @@ class MiqSchedule < ApplicationRecord | |||
| include Filters | |||
|
|
|||
| include YamlImportExportMixin | |||
| # TODO: towhat is a virtual alias? | |||
There was a problem hiding this comment.
deprecate_attribute shows up an alias and virtual attribute when I add instrumentation to virtual attributes... This TODO is really "do we have proper tests to know if rails 7.1 did or did not also break these...?"
jrafanie
force-pushed
the
rails71
branch
2 times, most recently
from
cacf7e3 to
791ae99
Compare
|
@jrafanie I'm thinking we need an |
This was referenced Feb 5, 2025
In ManageIQ#23171, we found that we weren't using the legacy connection handlers and disabled using them in rails 7.0. Now, in 7.1, this option has been removed, so it's safe to remove this option entirely.
Rails 7.1 removed the table_name alias to name so just use name: See: https://www.github.com/rails/rails/pull/46864 Rails 7.1 removed the writer for the table_alias so set the instance variable. We will need to see if there is a way to do this that's less brittle. See: https://www.github.com/rails/rails/pull/48927
It's unclear if it fixes all the issues as you can call alias_attribute anywhere up the ancestry tree and it's possible lazy loading is preventing them from being loaded. See: https://www.github.com/rails/rails/issues/52820 https://www.github.com/rails/rails/pull/52842 (7.1 backport: https://www.github.com/rails/rails/pull/52844) Looks like it's still an issue in some situations: https://www.github.com/rails/rails/issues/50154 https://www.github.com/rails/rails/issues/51717
Fixes deprecation of this variety: Foo model aliases `x`, but `x` is not an attribute. Starting in Rails 7.2, alias_attribute with non-attribute targets will raise. Use `alias_method :y, :x` or define the method manually.
This reverts commit e7acb3235e840aa89d479bf3993a08c53fc13e57. VERIFY we can drop this revert and the original commit pending due to https://www.github.com/ManageIQ/activerecord-virtual_attributes/pull/168
This reverts commit e4fa809. TODO Let's see if this is needed with rails 7.1
Note, rails 7.1 lazily load attribute methods so we can't use alias_method here.
Use runtime method delegation instead of class load time alias_method. Use single object for singular associations, *args for has manys. :shrug:
|
Checked commits jrafanie/manageiq@4b6d223~...0b6d445 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint Gemfile
app/models/miq_provision.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.