dont use rails runner to start evm_server.rb #6193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
worker_rails_runner
branch
from
a359cbf to
fb5fe79
Compare
|
Checked commit kbrock@fb5fe79 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had thought we were not going to run our app using rails runner, but just use basic rails environment instead.
I left our original stub so if it is run via rails runner, it will still work.
/cc @matthewd @Fryguy @jrafanie @chessbyte do you remember this discussion? Did something change?
/cc @matthewd can you remind us of the merits? Besides quicker start time and one less wrapper script?