[PoC] Asynchronous notifications using ActionCable #6809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
async-notify
branch
2 times, most recently
from
1bb3b88 to
f280068
Compare
skateman
force-pushed
the
async-notify
branch
3 times, most recently
from
58e7175 to
29eb161
Compare
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
9 tasks
skateman
force-pushed
the
async-notify
branch
2 times, most recently
from
aca20fb to
c3758d3
Compare
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
|
<github_pr_commenter_batch />Some comments on commit skateman@36b5db2 |
|
Checked commit skateman@36b5db2 with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1 |
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
skateman
changed the title
|
This was just a Proof-of-Concept PR, closing it in favor of #10965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this PR implements an asynchronous notification solution. Basically if you create a new
Notificationdatabase record, a callback function sends a notification to the client using ActionCable. The client is listening for notifications on its channel and displays them using PatternFly toast.Saving to the database is necessary because it is not guaranteed that the user is logged in. In the future, these database records can be disabled in the notification drawer also provided by the PatternFly guys.
Known issue when displaying multiple notifications at the same time:
patternfly/patternfly#323
ActionCable uses Redis by default! So make sure that you run bin/setup to copy the sample configuration which uses PostgreSQL!