BZ#1539862 - Created multiselect dialog field type #249
Conversation
|
Screenshot of it in action in a dialog in SUI |
|
Checked commits chalettu/ui-components@5fcb88d~...a571b51 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
| <select pf-select | ||
| ng-if="!vm.dialogField.options.force_multi_value" | ||
| ng-model="vm.dialogField.default_value" | ||
| ng-change="vm.changesHappened(item)" |
There was a problem hiding this comment.
Pretty sure item is undefined here.. $item used to be provided by ui-select, but looks like changesHappened does (value ? value[selectedValue] : this.dialogField.default_value), so maybe you can drop it and simplify the function a bit?
(same for the 2 other cases)
(Or am I missing something? :))
|
Looks like this should work 👍 |
|
Is this one good to merge? |
|
Um.. you tell me ;) |
|
As this is a fix for a blocker issue,...can we get this merged asap. @himdel who can merge? |
|
@JPrause understood, in that case, a stray undefined is probably not a problem, merging. |
|
@JPrause Is there any need to release a new version of ui-components now? (As opposed to Monday, in case there are other changes needed here.) |
|
@himdel thank you for merging. Let me know once we version bump ui-components because I need to update my WIP PR in SUI to reflect the new version. |
|
Aah, forgot the other PR was waiting for this too.. in that case, doing the release now.. |
|
Backported to the |
BZ#1539862 - Created multiselect dialog field type (cherry picked from commit 2bb4794)
|
Released @miq-bot add_label gaprindashvili/backported |
@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes
BZ https://bugzilla.redhat.com/show_bug.cgi?id=1539862