draft of section group feature #3990
Draft
+258
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Adds a group decorator to Scene that are basically "sections group".
Motivation and Explanation: Why and how do your changes improve the library?
For long videos you may want to have 2 levels of granularity for skipping/animation parts of the videos. Sections are the basic building block like a few animations and they are rendered in the same way as before.
You may add groups that behave like "chapters". They are a sequence of sections (you can still put sections inside groups) and the skipping/animation of section groups takes precedence over the individual section skipping/animation.
To make the distinction between sections and section groups the experimental API for sections is used. This way creating section is unchanged and we can gain the flexibility of the experimental API. Actually most of the code for the definition of a
SectionGroup
is taken from the experimentalSection
object.Links to added or changed documentation pages
The documentation must be done but the API is not stabilized. I'll wait for the namming to be correct before documenting.
It should go in the section page I think.
Additional comments
There is a feature in the SectionGroup object to make it become a full member of the Scene instance that I couldn't make work.
For now section groups must be called like
group(self)
.Reviewer Checklist