fixed problem with type conversions in Line3D #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
JasonGrace2282
requested changes
Dec 30, 2024
test.py
Outdated
There was a problem hiding this comment.
Did you mean to commit this?
There was a problem hiding this comment.
No. Should I?
Co-authored-by: Aarush Deshpande <[email protected]>
Co-authored-by: Aarush Deshpande <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
It prevent for passing wrong type of data in Line3D and Arrow3D.
Motivation and Explanation: Why and how do your changes improve the library?
It is inspired by this discord post, where point into Arrow3D has been passed as list of integers instead of floats, which broke subtraction during the Rotation. Right now, data will be automatically converted into the float64 format.
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist