Stable build is broken: Could not find RunIgnored in test

[dtolnay]

$ cargo +stable build --features stable
   Compiling compiletest_rs v0.3.14
error[E0433]: failed to resolve. Could not find `RunIgnored` in `test`
   --> src/lib.rs:101:52
    |
101 |         run_ignored: if config.run_ignored { test::RunIgnored::Yes } else { test::RunIgnored::No },
    |                                                    ^^^^^^^^^^ Could not find `RunIgnored` in `test`

error[E0433]: failed to resolve. Could not find `RunIgnored` in `test`
   --> src/lib.rs:101:83
    |
101 |         run_ignored: if config.run_ignored { test::RunIgnored::Yes } else { test::RunIgnored::No },
    |                                                                                   ^^^^^^^^^^ Could not find `RunIgnored` in `test`

[dtolnay]

Could you please yank 0.3.15 until this is fixed? I would like to prioritize keeping the stable build working over having nightly working.

[laumann]

Dang, this stable support is becoming a pain in the neck tbh :-/ I'll yank it.

[laumann]

Ok, yanked.

[dtolnay]

Thanks. I suspect that you are looking at this wrong: the stable support is dead simple -- just don't break anything. The nightly support is a pain in the neck. I filed #135 to follow up.

[Manishearth]

Clippy (and miri?) must test on nightly, please don't break nightly support. Stable crates can still test on nightly, the other way around doesn't work.

[Manishearth]

Oh, sorry, I was under the impression that you were proposing sacrificing nightly support for stable support, you want to remove the feature that makes nightly required in the first place, that makes sense

[dtolnay]

Correct. Clippy and miri are free to run tests against a nightly toolchain without requiring there to be unstable code in compiletest-rs.

[laumann]

Thanks. I suspect that you are looking at this wrong: the stable support is dead simple -- just don't break anything.

The way I see, the stable support is an added feature. It's definitely not a feature in rustc/compiletest. It was added because it was relatively simple to do at the time, but it's becoming more of a burden to maintain. Nightly support is simply just keeping up with rustc/compiletest. Fx the changes in #136 will have to be undone/changed when stable catches up to nightly (if I understand correctly). That's what I meant by pain in the neck :-)

But don't get me wrong, I'm happy to know that people use it! Both stable AND nightly :-)

[dtolnay]

I believe compiletest-rs would deliver a better experience if there weren't unstable code enabled by default.

[laumann]

0.3.16 is out.

[RalfJung]

@laumann thanks!

[SergioBenitez]

What is preventing compiletest from being (opt-in) independent of nightly releases? At the moment, you cannot compile the --features stable version of compiletest on nightly because of #136. Ideally, I'd like to be able to opt-in to nightly-only things, even on nightly, so that compiletest doesn't break my test suite.

[dtolnay]

@SergioBenitez that's what I would like to see. Tracked in #135.