Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call rotate_left instead of rotate. #102

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Feb 27, 2018

The rotate method has been deprecated in favor of rotate_left and rotate_right since rust-lang/rust#46777 (2018 Jan 10th), and will be deleted in rust-lang/rust#48450.

The `rotate` method has been deprecated in favor of `rotate_left` and `rotate_right` since rust-lang/rust#46777, and will be deleted in rust-lang/rust#48450.
@laumann
Copy link
Collaborator

laumann commented Feb 27, 2018

@kennytm Thanks :-) I've noticed this warning as well, but didn't do anything about it yet. I assume this has already been changed in rustc/compiletest?

@laumann
Copy link
Collaborator

laumann commented Feb 27, 2018

Yes it has (to answer my own question above).

@laumann laumann merged commit 5c48e01 into Manishearth:master Feb 27, 2018
@laumann
Copy link
Collaborator

laumann commented Feb 27, 2018

@kennytm I would assume that this is in no hurry to be released, so I'll just leave it here for now. Let me know if you'd like a patch release with this change.

@kennytm kennytm deleted the patch-1 branch February 27, 2018 16:12
@kennytm
Copy link
Contributor Author

kennytm commented Feb 27, 2018

@laumann Thanks. This is currently blocking a clippy test, which in turns blocks clippy from being updated in the main Rust repository (rust-lang/rust#48555). Since we did not ship clippy officially yet, this is not exactly urgent, but I still would like to see a release within 1 or 2 weeks.

@laumann
Copy link
Collaborator

laumann commented Feb 28, 2018

@kennytm Will you ping me in about a week then? Then I'll release a new version. That would give us time to add other things if necessary.

@dtolnay
Copy link
Contributor

dtolnay commented Mar 1, 2018

@laumann the deletion PR merged recently so compiletest-rs 0.3.6 no longer build as of rustc nightly-2018-03-01. I think this would be a good time to release a new version.

@laumann
Copy link
Collaborator

laumann commented Mar 1, 2018

@dtolnay On it

@laumann
Copy link
Collaborator

laumann commented Mar 1, 2018

0.3.7 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants