Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for parse_normalization_string #143

Closed
wants to merge 1 commit into from

Conversation

phansch
Copy link
Contributor

@phansch phansch commented Oct 29, 2018

This adds some unit tests for the parse_normalization_string function. Not
sure if this is really needed, but there's a FIXME inside the function that
could be resolved more easily with already existing unit tests.

If this is fine, should I also add the tests to rustc's compiletest?

Copy link
Contributor

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to upstream first -- src/tools/compiletest/src/header.rs. Then it will get picked up by this crate.

@phansch
Copy link
Contributor Author

phansch commented Dec 2, 2018

I'm going to close this, as I don't have enough time to work on this right now.

It looks like there is currently no easy way to execute the unit tests of compiletest inside rustc by themselves. A complete ./x.py test seems to be required currently.

@phansch phansch closed this Dec 2, 2018
@laumann
Copy link
Collaborator

laumann commented Dec 3, 2018

Hi @phansch Sorry for not picking this up.

What's needed to get it into rustc/compiletest? Just applying the patch and submitting a PR? If you don't mind, I might try to push it to rustc (obviously retaining your authorship).

@phansch
Copy link
Contributor Author

phansch commented Dec 13, 2018

@laumann Just that patch, yes. But I couldn't find a way to run the compiletest unit tests of rustc locally and didn't have time to wait for a full test build.

I'm not even sure if the unittests of compiletest in rustc are executed on CI, because the compiletest tool doesn't seem to be registered in the bootstrap script.

I just now asked on Discord if anyone knows how to run them.

@phansch
Copy link
Contributor Author

phansch commented Dec 13, 2018

Nevermind the previous comment. I went ahead and added support for running the rustc compiletest tests here: rust-lang/rust#56792 Once that's reviewed and merged, I will upstream this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants