[pre-commit.ci] pre-commit autoupdate

.pre-commit-config.yaml

@@ -6,7 +6,7 @@ default_language_version:
   python: python3.12
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.6.0
+    rev: v5.0.0
     hooks:
       - id: check-toml
       - id: trailing-whitespace
@@ -19,7 +19,7 @@ repos:
       - id: fix-byte-order-marker
   # Versions must be kept in sync with lockfile
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: 'v0.6.8'
+    rev: 'v0.9.4'
     hooks:
       - id: ruff
         args: [--fix, --exit-non-zero-on-fix]
@@ -30,14 +30,14 @@ repos:
       - id: yamllint
 
   - repo: https://github.com/rtts/djhtml
-    rev: '3.0.6'
+    rev: '3.0.7'
     hooks:
       - id: djhtml
       - id: djcss
       - id: djjs
 
   - repo: https://github.com/adamchainz/djade-pre-commit
-    rev: "1.1.1"
+    rev: "1.3.2"
     hooks:
       - id: djade
         args: [--target-version, "4.2"]

scripts/gen_credits.py

@@ -53,12 +53,12 @@ def _get_license(pkg_name: str) -> str:
         data = metadata(pkg_name)
     except PackageNotFoundError:
         return "?"
-    license_name = cast(dict, data).get("License", "").strip()
+    license_name = cast("dict", data).get("License", "").strip()
     multiple_lines = bool(license_name.count("\n"))
     # TODO: Remove author logic once all my packages licenses are fixed.
     author = ""
     if multiple_lines or not license_name or license_name == "UNKNOWN":
-        for header, value in cast(dict, data).items():
+        for header, value in cast("dict", data).items():
             if header == "Classifier" and value.startswith("License ::"):
                 license_name = value.rsplit("::", 1)[1].strip()
             elif header == "Author-email":

src/firefighter/api/models.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
 import uuid
 from typing import TYPE_CHECKING, ClassVar, Self, cast
 
 from django.conf import settings
@@ -26,7 +26,7 @@
 
     @property
     def pk(self: Self) -> uuid.UUID:
-        return cast(uuid.UUID, self.user_id)  # pyright: ignore[reportGeneralTypeIssues]
+        return cast("uuid.UUID", self.user_id)  # pyright: ignore[reportGeneralTypeIssues]
 
     class Meta(TypedModelMeta):
         permissions = [

src/firefighter/confluence/tasks/sync_postmortems.py

@@ -56,7 +56,7 @@ def sync_postmortems() -> None:
         if not Incident.objects.filter(id=incident_id).exists():
             pm_missing_incident.append(data["name"])
             continue
-        data_editable = cast(dict[str, str], data)
+        data_editable = cast("dict[str, str]", data)
         try:
             PostMortem.objects.update_or_create(
                 page_id=int(data_editable.pop("page_id")),

src/firefighter/confluence/tasks/sync_runbooks.py

@@ -47,7 +47,7 @@ def sync_runbooks() -> None:
             all_fetched_ids.add(page_id)
             data["name"] = data["name"].removesuffix("[RUNBOOK]").strip()
 
-            data_editable = cast(dict[str, str], data)
+            data_editable = cast("dict[str, str]", data)
             data_editable["title"] = (
                 data_editable["name"].removesuffix("[RUNBOOK]").strip()
             )

src/firefighter/firefighter/filters.py

@@ -7,13 +7,13 @@
 
 import markdown as md
 import nh3
 from django import template
 from django.template.defaulttags import register as register_base
 
 if TYPE_CHECKING:
     from collections.abc import Callable
 
-register_global: template.Library = cast(template.Library, register_base)
+register_global: template.Library = cast("template.Library", register_base)
 V = TypeVar("V")
 
 

src/firefighter/jira_app/client.py

@@ -315,7 +315,7 @@ def _get_project_config_workflow_base(
         # XXX Try catch
         # XXX Override Jira Class / split client and service
         return cast(
-            dict[str, Any],
+            "dict[str, Any]",
             self.jira._session.get(  # noqa: SLF001
                 url,
                 headers=self.jira._options["headers"],  # noqa: SLF001
@@ -372,8 +372,8 @@ def _get_project_config_workflow_from_builder_base(
                 del status["y"]
 
         return WorkflowBuilderResponse(
-            statuses=cast(list[Status], statuses),
-            transitions=cast(list[Transition], transitions),
+            statuses=cast("list[Status]", statuses),
+            transitions=cast("list[Transition]", transitions),
         )
 
     @staticmethod

src/firefighter/logging/custom_json_formatter.py

@@ -15,7 +15,7 @@
 DD_TRACE_ENABLED = os.environ.get("DD_TRACE_ENABLED")
 if DD_TRACE_ENABLED:
     from ddtrace import tracer
-GUNICORN_KEY_RE = re.compile("{([^}]+)}")
+GUNICORN_KEY_RE = re.compile(r"{([^}]+)}")
 
 
 def del_if_possible(obj: dict[str, Any], key: str) -> None:

src/firefighter/raid/client.py

@@ -175,7 +175,7 @@ def _get_project_config_workflow_from_builder(self) -> WorkflowBuilderResponse:
     @staticmethod
     def _jira_object(issue: dict[str, Any]) -> JiraObject:
         if issue_id := issue.get("id"):
-            jira_id = int(cast(str, issue_id))
+            jira_id = int(cast("str", issue_id))
         else:
             raise TypeError("Jira ID not found")
 

src/firefighter/slack/views/modals/base_modal/mixins.py

@@ -41,8 +41,7 @@ def build_modal_with_context(self, body: dict[str, Any], **kwargs: Any) -> View:
         if "incident" in self.builder_fn_args and kwargs.get("incident") is None:
             if kwargs.get("callback_id") is None:
                 kwargs["callback_id"] = self.callback_id
-            if "body" in kwargs:
-                del kwargs["body"]
+            kwargs.pop("body", None)
             return modal_select.build_modal_fn(**kwargs, select_class=self)
 
         return self.build_modal_fn(**kwargs)  # type: ignore

src/firefighter/slack/views/modals/open.py

@@ -372,7 +372,7 @@ def _build_response_type_blocks(open_incident_context: OpeningData) -> list[Bloc
             return []
 
         response_types: list[ResponseType] = cast(
-            list[ResponseType], INCIDENT_TYPES.keys()
+            "list[ResponseType]", INCIDENT_TYPES.keys()
         )
         elements: list[ButtonElement] = []
 
@@ -512,7 +512,7 @@ def handle_set_incident_response_type_action(
         action_name: str = body.get("actions", [{}])[0].get("action_id", "")
         action_name = action_name.replace("incident_open_set_res_type_", "")
         opening_data = cast(
-            OpeningData, json.loads(body.get("actions", [{}])[0].get("value", {})) or {}
+            "OpeningData", json.loads(body.get("actions", [{}])[0].get("value", {})) or {}
         )
 
         OpenModal._update_incident_modal(

src/firefighter/slack/views/modals/opening/select_impact.py

@@ -16,7 +16,7 @@
 
 from firefighter.firefighter.utils import get_in
 from firefighter.incidents.forms.select_impact import SelectImpactForm
 from firefighter.incidents.models.impact import ImpactLevel
 from firefighter.incidents.models.priority import Priority
 from firefighter.slack.slack_app import SlackApp
 from firefighter.slack.views.modals import modal_open
@@ -146,7 +146,7 @@
     ) -> None:
         body = request.body
         data = cast(
-            OpeningData, json.loads(body.get("actions", [{}])[0].get("value", {})) or {}
+            "OpeningData", json.loads(body.get("actions", [{}])[0].get("value", {})) or {}
         )
         view = self.build_modal_fn(body, open_incident_context=data)
         request.context.ack()
@@ -192,7 +192,7 @@
                 and not isinstance(form.form.data[field_name], Model)
                 and field.queryset is not None
             ):
-                queryset = cast(QuerySet[ImpactLevel], field.queryset)
+                queryset = cast("QuerySet[ImpactLevel]", field.queryset)
                 try:
                     form.form.data[field_name] = queryset.get(  # type: ignore
                         pk=form.form.data[field_name]
@@ -206,7 +206,7 @@
             response_type=SelectImpactModal._calculate_proposed_incident_type(
                 form.form.suggest_priority_from_impact()
             ),
-            impact_form_data=cast(dict[str, Any], form.form.data),
+            impact_form_data=cast("dict[str, Any]", form.form.data),
             details_form_data=private_metadata_raw.get("details_form_data", {}),
             incident_type=private_metadata_raw.get("incident_type"),
         )

src/firefighter/slack/views/modals/opening/set_details.py

@@ -127,7 +127,7 @@ def handle_modal_fn(  # type: ignore
                 pk=private_metadata["priority"]
             )
         data = OpeningData(
-            details_form_data=cast(dict[str, Any], form.data),
+            details_form_data=cast("dict[str, Any]", form.data),
             impact_form_data=private_metadata.get("impact_form_data"),
             incident_type=private_metadata.get("incident_type"),
             response_type=private_metadata.get("response_type"),