refactor(catalog): storybook for each package & composed storybook #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
August 12, 2020 14:36
- [email protected] - [email protected] - @map-colonies/[email protected] - @map-colonies/[email protected]
- [email protected] - [email protected] - @map-colonies/[email protected] - @map-colonies/[email protected]
BREAKING CHANGE: lerna, core comps
…ents into mc-wc-ui-components
- [email protected] - [email protected] - @map-colonies/[email protected] - @map-colonies/[email protected] - @map-colonies/[email protected] - @map-colonies/[email protected]
- [email protected] - [email protected] - @map-colonies/[email protected] - @map-colonies/[email protected]
Tests Infrastructure
alebinson
requested changes
Sep 1, 2020
| refs: { | ||
| react_components: { | ||
| title: "React Components", | ||
| url: "http://localhost:9010" |
There was a problem hiding this comment.
Do we publish story books?
http://localhost:9010 is for development
There was a problem hiding this comment.
we will publish them in the future, for now it's only for development
| }, | ||
| react_ui_components: { | ||
| title: "React UI Components", | ||
| url: "http://localhost:9011" |
There was a problem hiding this comment.
Do we publish story books?
http://localhost:9010 is for development
README.md
Outdated
|
|
||
| The repo uses [Yarn workspaces](https://classic.yarnpkg.com/en/docs/workspaces/) to link dependencies, and to enable running `yarn install` once. | ||
|
|
||
| **You should use yarn instead of npm.** | ||
|
|
||
|
|
||
| ## Projects | ||
| * **mc-conflict-ui** - UI app for resolving conflicts. | ||
| * **mc-react-components** - Component library for shared components. | ||
| * **demoapp-react** - UI app as a demo for using react components. |
There was a problem hiding this comment.
it's an old code, merge from master is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with the composed storybook, I'm waiting for support from
storybookjs.related issue storybookjs/storybook#11892