Remove deprecated input types xmin,ymin,xmax,ymax,projection. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove action,enctype,method attributes. Update description of <extent> element. Resolves Maps4HTML#76 Overal, description of <extent> still needs improvement, because since the removal of the action attribute, the meaning of extent has shifted slightly. Now that the requests for content are driven by link templates and associated inputs, an extent is represented the union of the extents of the templates, which is dictated by the min/ max values of the axes of the location inputs.
Malvoz
requested changes
Jul 18, 2020
There was a problem hiding this comment.
This line has a mention of extent@action:
https://github.com/Maps4HTML/MapML/blob/ec2a4ca58baf48fdedcf0b5d92421237eb11431a/spec/index.html#L1280
Malvoz
approved these changes
Jul 19, 2020
Malvoz
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove action,enctype,method attributes.
Update description of
<extent>element.Resolves #61
Resolves #76
Closes #37
Overal, description of
<extent>still needs improvement,because since the removal of the action attribute, the meaning of
extent has shifted slightly. Now that the requests for content are
driven by link templates and associated inputs, an extent is represented
the union of the extents of the templates, which is dictated by the min/
max values of the axes of the location inputs.