Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are some wrongs with nnp_fully_connected_output #44

Closed
hfbluehf opened this issue Jan 3, 2017 · 1 comment
Closed

There are some wrongs with nnp_fully_connected_output #44

hfbluehf opened this issue Jan 3, 2017 · 1 comment

Comments

@hfbluehf
Copy link

hfbluehf commented Jan 3, 2017

hello, @Maratyszcza
I find there are some wrongs with nnp_fully_connected_output, if batch-size != 4*n.
My config is x86_64-fma, and threadpool is null.

And I find that, at NNPACK-master\src\fully-connected-output.c Line 40.
If change the 'outer_subblock_max' to 'outer_subblock_size', can fix this problem.

I would like to know whether my amendment is reasonable.
And will it affect efficiency?

@tornadomeet
Copy link

oh, i found some simillar: #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants