Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Current ruleset "Review needed" requires a pull request before merging #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tecoad
Copy link
Collaborator

@tecoad tecoad commented Aug 14, 2024

@MarcosNicolau
Current GH action for release 'semantic-release' is trying to push changes (version updates and tags) directly to the main branch as can be seen here, which is nonetheless being blocked by the current repository rules.

We have three possible workarounds:

  1. Modify repository rules.
  2. Use a different branch for releases.
  3. Use semantic-release's GitHub Action
    This GitHub Action for semantic-release that might handle these permissions better (i never used it though, so we have to test it). Why this PR does.

Feel free to take the best approach in your opinion.

@MarcosNicolau
Copy link
Owner

MarcosNicolau commented Aug 14, 2024

I was about to address this problem. Your solution looks good, but I don't think it will work since it requires creating a personal access token with the necessary permissions, which adds the overhead of making sure we are not persisting credentials. For now, I'm gonna re-trigger the ci and disable the branch rules, which I just added to know if another contributor(you) has viewed and approved the changes(saving me some work haha). Let's leave the pr open though, I liked the comment and the workaround list 😄

@lukas-becker0
Copy link
Contributor

lukas-becker0 commented Aug 22, 2024

Also can we squash the commits of PRs before merging ?

@MarcosNicolau
Copy link
Owner

Also can we squash the commits of PRs before merging ?

Just added that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants