Refactor master cfg #686
Draft
Refactor master cfg #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove star imports * master-private.cfg always loaded from base directory for all masters.
buildbot.tac as the entrypoint for a buildbot master should use relative paths based on the deployment directory structure. Furthermore, the basedir should be set to <srcdir> so that all imports will work relative to <srcdir>, not the location of buildbot.tac or master.cfg.
Simplify and ensure it returns a 3-value tuple.
This will remove code duplication across master.cfg files.
* Also fixup unescaped backslashes in strings
* Also simplify branch matching functions
* os_info.yaml now provides tags / os * os_info.yaml specifies directly the image tag. This removes the need to do transformations within buildbot configuration code. * define_masters no longer generates a custom buildbot.tac by replacing the log file for the master with a custom name. buildbot.tac now uses a log file based on the master directory. * master-config.yaml now groups builders by architecture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup PR that should not impact the builders / workers actually running tests.