-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
track #12
base: master
Are you sure you want to change the base?
track #12
Conversation
301caa5
to
e90636f
Compare
e90636f
to
3ec296d
Compare
if (func->HasNonzeroAttr(attr::kPrimitive)) { | ||
return ConstEvaluateFunc(func); | ||
// return ConstEvaluateFunc(func); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this dead code if you don't do anything in the body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is debug stuff. i havent clean up yet
@@ -1004,7 +1034,6 @@ IRModule VMCompiler::OptimizeModule(const IRModule& mod, const TargetsMap& targe | |||
} | |||
|
|||
void VMCompiler::PopulateGlobalMap() { | |||
// First we populate global map. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just lift this comment on to the function and expand it instead of removing it?
@@ -104,7 +104,23 @@ class ConstantFolder : public ExprMutator { | |||
} | |||
} | |||
|
|||
bool inside_primitive = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you group this variable with any other field declarations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you improve your PR titles and commit messages a lot of the value of PRs is for historical record, not just for the people at the time you write the code.
@jroesch I think you misunderstood... this is just a PR to track all the difference of my internal version to mainline, where I split small PR from here. |
save
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.