Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

track #12

wants to merge 2 commits into from

Conversation

MarisaKirisame
Copy link
Owner

save

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@MarisaKirisame MarisaKirisame force-pushed the upstream branch 2 times, most recently from 301caa5 to e90636f Compare August 25, 2020 20:29
save

fix
if (func->HasNonzeroAttr(attr::kPrimitive)) {
return ConstEvaluateFunc(func);
// return ConstEvaluateFunc(func);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this dead code if you don't do anything in the body?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is debug stuff. i havent clean up yet

@@ -1004,7 +1034,6 @@ IRModule VMCompiler::OptimizeModule(const IRModule& mod, const TargetsMap& targe
}

void VMCompiler::PopulateGlobalMap() {
// First we populate global map.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just lift this comment on to the function and expand it instead of removing it?

@@ -104,7 +104,23 @@ class ConstantFolder : public ExprMutator {
}
}

bool inside_primitive = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you group this variable with any other field declarations?

Copy link
Collaborator

@jroesch jroesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve your PR titles and commit messages a lot of the value of PRs is for historical record, not just for the people at the time you write the code.

@MarisaKirisame
Copy link
Owner Author

@jroesch I think you misunderstood... this is just a PR to track all the difference of my internal version to mainline, where I split small PR from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants