Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marke16/improvements 1 #23

Merged
merged 56 commits into from
Feb 24, 2025
Merged

Marke16/improvements 1 #23

merged 56 commits into from
Feb 24, 2025

Conversation

MarkE16
Copy link
Owner

@MarkE16 MarkE16 commented Dec 30, 2024

Description

Shapes and tests (created this pr just to set up sonarqube

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)

Have you tested your changes?

  • I wrote tests for the code I've written.

Repository owner deleted a comment from vercel bot Jan 15, 2025
@MarkE16
Copy link
Owner Author

MarkE16 commented Jan 28, 2025

Note: The text tool is still not considered production ready. However, I will be implementing feature flags via Growthbook, that way I can ship these new features and improvements while the text tool is still being under development.

@MarkE16 MarkE16 marked this pull request as draft February 23, 2025 02:21
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@MarkE16
Copy link
Owner Author

MarkE16 commented Feb 24, 2025

Due to many changes that have been made and how different the main branch is compared to the current version, I am deciding to merge this early. The text tool still has some bugs, but it's close to being finished. So, instead the text tool will be disabled by being hard coded as disabled. Later on, the text tool will continue to be developed.

@MarkE16 MarkE16 marked this pull request as ready for review February 24, 2025 03:25
@MarkE16 MarkE16 merged commit a306d72 into main Feb 24, 2025
1 of 2 checks passed
@MarkE16 MarkE16 deleted the marke16/improvements_1 branch February 24, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant