Hide virtual attributes from solutioncomponent entity

Fixes #524
MarkMpn · Aug 19, 2024 · 02793eb · 02793eb
1 parent c6efe10
commit 02793eb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/MarkMpn.Sql4Cds.Engine/ExecutionPlan/ExpressionExtensions.cs b/MarkMpn.Sql4Cds.Engine/ExecutionPlan/ExpressionExtensions.cs
@@ -1495,6 +1495,9 @@ private static Expression ToExpression(this InPredicate inPred, ExpressionCompil
                 cacheKey += comparisonCacheKey;
             }
 
+            if (ex != null)
+                throw ex;
+
             cacheKey += ")";
             sqlType = DataTypeHelpers.Bit;
             return result;

diff --git a/MarkMpn.Sql4Cds.Engine/MetadataExtensions.cs b/MarkMpn.Sql4Cds.Engine/MetadataExtensions.cs
@@ -69,7 +69,9 @@ public static IEnumerable<VirtualAttribute> GetVirtualAttributes(this AttributeM
 
             if (attrMetadata is LookupAttributeMetadata lookup)
             {
-                if (!writeable)
+                // solutioncomponent entity doesn't return the names of lookup values
+                // https://github.com/MarkMpn/Sql4Cds/issues/524
+                if (!writeable && attrMetadata.EntityLogicalName != "solutioncomponent")
                     yield return new VirtualAttribute("name", DataTypeHelpers.NVarChar(lookup.Targets == null || lookup.Targets.Length == 0 ? 100 : lookup.Targets.Select(e => (dataSource.Metadata[e].Attributes.SingleOrDefault(a => a.LogicalName == dataSource.Metadata[e].PrimaryNameAttribute) as StringAttributeMetadata)?.MaxLength ?? 100).Max(), dataSource.DefaultCollation, CollationLabel.Implicit), null);
 
                 if (lookup.Targets?.Length != 1 && lookup.AttributeType != AttributeTypeCode.PartyList)