Standardised checking for missing records on UPDATE/DELETE

MarkMpn · Sep 15, 2024 · 0ea9df9 · 0ea9df9
1 parent 3324c5f
commit 0ea9df9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/MarkMpn.Sql4Cds.Engine/ExecutionPlan/DeleteNode.cs b/MarkMpn.Sql4Cds.Engine/ExecutionPlan/DeleteNode.cs
@@ -275,7 +275,9 @@ protected override bool FilterErrors(NodeExecutionContext context, OrganizationR
         {
             // Ignore errors trying to delete records that don't exist - record may have been deleted by another
             // process in parallel.
-            return fault.ErrorCode != -2147220891 && fault.ErrorCode != -2147185406 && fault.ErrorCode != -2147220969 && fault.ErrorCode != 404;
+            return fault.ErrorCode != -2147185406 && // IsvAbortedNotFound
+                fault.ErrorCode != -2147220969 && // ObjectDoesNotExist
+                fault.ErrorCode != 404; // Elastic tables
         }
 
         protected override ExecuteMultipleResponse ExecuteMultiple(DataSource dataSource, IOrganizationService org, EntityMetadata meta, ExecuteMultipleRequest req)

diff --git a/MarkMpn.Sql4Cds.Engine/ExecutionPlan/UpdateNode.cs b/MarkMpn.Sql4Cds.Engine/ExecutionPlan/UpdateNode.cs
@@ -591,7 +591,9 @@ protected override bool FilterErrors(NodeExecutionContext context, OrganizationR
         {
             // Ignore errors trying to update records that don't exist - record may have been deleted by another
             // process in parallel.
-            return fault.ErrorCode != -2147220969 && fault.ErrorCode != -2147185406 && fault.ErrorCode != -2147220969 && fault.ErrorCode != 404;
+            return fault.ErrorCode != -2147185406 && // IsvAbortedNotFound
+                fault.ErrorCode != -2147220969 && // ObjectDoesNotExist
+                fault.ErrorCode != 404; // Elastic tables
         }
 
         protected override ExecuteMultipleResponse ExecuteMultiple(DataSource dataSource, IOrganizationService org, EntityMetadata meta, ExecuteMultipleRequest req)