Do not fold NOT IN queries using an inner join to a left outer join

Fixes #382
MarkMpn · Nov 3, 2023 · 749b9e5 · 749b9e5
1 parent 624e423
commit 749b9e5
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/MarkMpn.Sql4Cds.Engine/ExecutionPlan/FilterNode.cs b/MarkMpn.Sql4Cds.Engine/ExecutionPlan/FilterNode.cs
@@ -893,6 +893,11 @@ private bool FoldInExistsToFetchXml(NodeCompilationContext context, IList<Optimi
                     // We can fold NOT IN to a left outer join, using similar rules to IN on the primary key
                     else if (!nullFilter.IsNot && rightFetch.FetchXml.top == null)
                     {
+                        // Can't add an outer join if the right side includes an inner join
+                        // https://github.com/MarkMpn/Sql4Cds/issues/382
+                        if (rightFetch.Entity.GetLinkEntities().Any(l => l.linktype == "inner"))
+                            break;
+
                         // Replace the filter on the defined value name with a filter on the primary key column
                         nullFilter.Expression = (rightFetch.Alias + "." + context.DataSources[rightFetch.DataSource].Metadata[rightFetch.Entity.name].PrimaryIdAttribute).ToColumnReference();