Fixes

AzureDataStudioExtension/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Change Log
 
+## [v7.5.0](https://github.com/MarkMpn/Sql4Cds/releases/tag/v7.5.0) - 2023-09-03
+
+Added `sql_variant` type support, including `SQL_VARIANT_PROPERTY` function
+Added `IS [NOT] DISTINCT FROM` predicate support
+Added `@@SERVERNAME` and `@@VERSION` global variables
+Added `SERVERPROPERTY` function support
+Added `USE_LEGACY_UPDATE_MESSAGES` query hint to use legacy update messages `Assign`, `SetState`, `SetParentBusinessUnit` and `SetBusinessEquipment`
+
+Subquery fixes:
+- Only include requested columns from `CROSS APPLY` and query-defined tables
+- Performance improvements for uncorrelated scalar subqueries
+- Only retrieve minimal rows for scalar subqueries
+- Fixed use of nested `IN` and `EXISTS` subqueries
+
+Fixed use of table-valued function with alias
+Fixed `JSON_VALUE` function with embedded null literals
+Fixed bulk DML operations that require non-standard requests
+Do not use merge joins for data types with different sort ordering
+Fixed filtering and sorting on non-lowercase attributes
+Fixed executing messages with OptionSetValue parameters
+Improved error reporting on batch DML statements
+
+Added autocomplete for collation names and variable names
+
 ## [v7.4.0](https://github.com/MarkMpn/Sql4Cds/releases/tag/v7.4.0) - 2023-08-05
 
 Added support for long-term retention data

MarkMpn.Sql4Cds.Controls/MarkMpn.Sql4Cds.Controls.csproj

@@ -171,4 +171,7 @@
     <EmbeddedResource Include="Images\XmlWriterNode.ico" />
   </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
+    <PostBuildEvent>copy $(TargetDir)MarkMpn.Sql4Cds.Controls.dll %25appdata%25\MscrmTools\XrmToolBox\Plugins\MarkMpn.Sql4Cds</PostBuildEvent>
+  </PropertyGroup>
 </Project>

MarkMpn.Sql4Cds.Controls/Properties/AssemblyInfo.cs

@@ -8,9 +8,9 @@
 [assembly: AssemblyTitle("MarkMpn.Sql4Cds.Controls")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
-[assembly: AssemblyCompany("")]
+[assembly: AssemblyCompany("Mark Carrington")]
 [assembly: AssemblyProduct("MarkMpn.Sql4Cds.Controls")]
-[assembly: AssemblyCopyright("Copyright ©  2022")]
+[assembly: AssemblyCopyright("Copyright © 2022 - 2023 Mark Carrington")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 
@@ -34,3 +34,4 @@
 // [assembly: AssemblyVersion("1.0.*")]
 [assembly: AssemblyVersion("1.0.0.0")]
 [assembly: AssemblyFileVersion("1.0.0.0")]
+[assembly: AssemblyInformationalVersion("1.0.0.0")]

MarkMpn.Sql4Cds.Engine.NetCore/MarkMpn.Sql4Cds.Engine.NetCore.csproj

@@ -4,6 +4,7 @@
     <TargetFramework>net6.0</TargetFramework>
     <AssemblyName>MarkMpn.Sql4Cds.Engine</AssemblyName>
     <RootNamespace>MarkMpn.Sql4Cds.Engine</RootNamespace>
+    <Copyright>Copyright © 2020 - 2023 Mark Carrington</Copyright>
   </PropertyGroup>
 
   <Import Project="..\MarkMpn.Sql4Cds.Engine\MarkMpn.Sql4Cds.Engine.projitems" Label="Shared" />

MarkMpn.Sql4Cds.Engine.NetFx/MarkMpn.Sql4Cds.Engine.NetFx.csproj

@@ -87,4 +87,12 @@
   </ItemGroup>
   <Import Project="..\MarkMpn.Sql4Cds.Engine\MarkMpn.Sql4Cds.Engine.projitems" Label="Shared" />
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
+    <PostBuildEvent>copy $(TargetDir)MarkMpn.Sql4Cds.Engine.dll %25appdata%25\MscrmTools\XrmToolBox\Plugins\MarkMpn.Sql4Cds
+copy $(TargetDir)Microsoft.ApplicationInsights.dll %25appdata%25\MscrmTools\XrmToolBox\Plugins\MarkMpn.Sql4Cds
+copy $(TargetDir)Microsoft.SqlServer.TransactSql.ScriptDom.dll %25appdata%25\MscrmTools\XrmToolBox\Plugins\MarkMpn.Sql4Cds
+copy $(TargetDir)XPath2.dll %25appdata%25\MscrmTools\XrmToolBox\Plugins\MarkMpn.Sql4Cds
+copy $(TargetDir)XPath2.Extensions.dll %25appdata%25\MscrmTools\XrmToolBox\Plugins\MarkMpn.Sql4Cds
+</PostBuildEvent>
+  </PropertyGroup>
 </Project>

MarkMpn.Sql4Cds.Engine.NetFx/Properties/AssemblyInfo.cs

@@ -10,7 +10,7 @@
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("Mark Carrington")]
 [assembly: AssemblyProduct("MarkMpn.Sql4Cds.Engine")]
-[assembly: AssemblyCopyright("Copyright ©  2020")]
+[assembly: AssemblyCopyright("Copyright © 2020 - 2023 Mark Carrington")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 

MarkMpn.Sql4Cds.Engine.Tests/AdoProviderTests.cs

@@ -834,6 +834,25 @@ public void StoredProcedureCommandType()
             }
         }
 
+        [TestMethod]
+        public void AliasedTVF()
+        {
+            using (var con = new Sql4CdsConnection(_localDataSource))
+            using (var cmd = con.CreateCommand())
+            {
+                cmd.CommandText = "SELECT msg.* FROM SampleMessage('1') AS msg";
+
+                using (var reader = cmd.ExecuteReader())
+                {
+                    Assert.IsTrue(reader.Read());
+                    Assert.AreEqual("1", reader.GetString(0));
+                    Assert.AreEqual(1, reader.GetInt32(1));
+
+                    Assert.IsFalse(reader.Read());
+                }
+            }
+        }
+
         [TestMethod]
         public void CorrelatedNotExistsTypeConversion()
         {
@@ -1304,5 +1323,175 @@ public void StringAgg()
                 Assert.AreEqual("C, B, A", actual);
             }
         }
+
+        [TestMethod]
+        public void JsonValueNull()
+        {
+            using (var con = new Sql4CdsConnection(_localDataSource))
+            using (var cmd = con.CreateCommand())
+            {
+                cmd.CommandText = "SELECT JSON_VALUE('{ \"changedAttributes\": [ { \"logicalName\": \"column1\", \"oldValue\": null, \"newValue\": \"\" } ] }', '$.changedAttributes[0].oldValue')";
+                Assert.AreEqual(DBNull.Value, cmd.ExecuteScalar());
+            }
+        }
+
+        [TestMethod]
+        public void VariantType()
+        {
+            using (var con = new Sql4CdsConnection(_localDataSource))
+            using (var cmd = con.CreateCommand())
+            {
+                // Can select two variant values of different types in the same column
+                cmd.CommandText = "SELECT SERVERPROPERTY('edition') UNION ALL SELECT SERVERPROPERTY('editionid')";
+
+                using (var reader = cmd.ExecuteReader())
+                {
+                    Assert.IsTrue(reader.Read());
+                    Assert.AreEqual("Enterprise Edition", reader.GetString(0));
+                    Assert.IsTrue(reader.Read());
+                    Assert.AreEqual(1804890536, reader.GetInt64(0));
+                    Assert.IsFalse(reader.Read());
+                }
+            }
+        }
+
+        [TestMethod]
+        public void VariantComparisons()
+        {
+            using (var con = new Sql4CdsConnection(_localDataSource))
+            using (var cmd = con.CreateCommand())
+            {
+                // Variant values are compared according to the type family hierarchy
+                // https://dba.stackexchange.com/questions/56722/why-does-implicit-conversion-from-sql-variant-basetype-decimal-not-work-well-w
+                cmd.CommandText = @"
+declare
+    @v sql_variant = convert(decimal(28,8), 20.0);
+
+select sql_variant_property(@v, 'BaseType') as BaseType,         -- 'decimal',
+       iif(convert(int, 10.0)     < @v, 1, 0) as ResultInt,      -- 1
+       iif(convert(decimal, 10.0) < @v, 1, 0) as  ResultDecimal, -- 1
+       iif(convert(float, 10.0)   < @v, 1, 0) as  ResultFloat,   -- 0 !
+       iif(convert(float, 10.0)   < convert(float, @v), 1, 0) as  ResultFloatFloat,  -- 1              
+       iif(convert(float, 10.0)   < convert(decimal(28,8), @v), 1, 0) as  ResultFloatDecimal;   -- 1";
+
+                using (var reader = cmd.ExecuteReader())
+                {
+                    Assert.IsTrue(reader.Read());
+
+                    var i = 0;
+                    Assert.AreEqual("decimal", reader.GetString(i++));
+                    Assert.AreEqual(1, reader.GetInt32(i++));
+                    Assert.AreEqual(1, reader.GetInt32(i++));
+                    Assert.AreEqual(0, reader.GetInt32(i++));
+                    Assert.AreEqual(1, reader.GetInt32(i++));
+                    Assert.AreEqual(1, reader.GetInt32(i++));
+
+                    Assert.IsFalse(reader.Read());
+                }
+            }
+        }
+
+        [TestMethod]
+        public void SqlVariantProperty()
+        {
+            using (var con = new Sql4CdsConnection(_localDataSource))
+            using (var cmd = con.CreateCommand())
+            {
+                // Variant values are compared according to the type family hierarchy
+                // https://dba.stackexchange.com/questions/56722/why-does-implicit-conversion-from-sql-variant-basetype-decimal-not-work-well-w
+                cmd.CommandText = @"
+declare
+    @v sql_variant = cast (46279.1 as decimal(8,2));
+
+SELECT   SQL_VARIANT_PROPERTY(@v,'BaseType') AS 'Base Type',  
+         SQL_VARIANT_PROPERTY(@v,'Precision') AS 'Precision',  
+         SQL_VARIANT_PROPERTY(@v,'Scale') AS 'Scale' ";
+
+                using (var reader = cmd.ExecuteReader())
+                {
+                    Assert.IsTrue(reader.Read());
+
+                    var i = 0;
+                    Assert.AreEqual("decimal", reader.GetString(i++));
+                    Assert.AreEqual(8, reader.GetInt32(i++));
+                    Assert.AreEqual(2, reader.GetInt32(i++));
+
+                    Assert.IsFalse(reader.Read());
+                }
+            }
+        }
+
+        [TestMethod]
+        public void VariantTypes()
+        {
+            using (var con = new Sql4CdsConnection(_localDataSource))
+            using (var cmd = con.CreateCommand())
+            {
+                // Variant values are compared according to the type family hierarchy
+                // https://dba.stackexchange.com/questions/56722/why-does-implicit-conversion-from-sql-variant-basetype-decimal-not-work-well-w
+                cmd.CommandText = @"
+declare
+    @v sql_variant = 1;
+declare
+    @n sql_variant;
+
+SELECT   @v
+UNION ALL
+SELECT   @n";
+
+                using (var reader = (Sql4CdsDataReader) cmd.ExecuteReader())
+                {
+                    Assert.AreEqual(typeof(object), reader.GetProviderSpecificFieldType(0));
+                    Assert.AreEqual(typeof(object), reader.GetFieldType(0));
+                    Assert.AreEqual("sql_variant", reader.GetDataTypeName(0));
+
+                    var schema = reader.GetSchemaTable();
+                    Assert.AreEqual(typeof(object), schema.Rows[0]["DataType"]);
+                    Assert.AreEqual(typeof(object), schema.Rows[0]["ProviderSpecificDataType"]);
+
+                    Assert.IsTrue(reader.Read());
+
+                    Assert.AreEqual(1, reader.GetInt32(0));
+                    Assert.AreEqual(1, reader.GetValue(0));
+                    Assert.AreEqual(new SqlInt32(1), reader.GetProviderSpecificValue(0));
+
+                    Assert.IsTrue(reader.Read());
+
+                    Assert.AreEqual(DBNull.Value, reader.GetValue(0));
+                    Assert.AreEqual(DBNull.Value, reader.GetProviderSpecificValue(0));
+
+                    Assert.IsFalse(reader.Read());
+                }
+            }
+        }
+
+        [TestMethod]
+        public void ExecSetState()
+        {
+            using (var con = new Sql4CdsConnection(_localDataSource))
+            using (var cmd = con.CreateCommand())
+            {
+                cmd.CommandText = "INSERT INTO contact (firstname, lastname) VALUES ('Test', 'User'); SELECT @@IDENTITY";
+                var id = cmd.ExecuteScalar();
+
+                cmd.CommandText = @"
+DECLARE @id EntityReference
+SELECT TOP 1 @id = contactid FROM contact
+EXEC SetState @id, 1, 2";
+
+                cmd.ExecuteNonQuery();
+
+                cmd.CommandText = "SELECT statecode, statuscode FROM contact WHERE contactid = @id";
+                cmd.Parameters.Add(new Sql4CdsParameter("@id", id));
+
+                using (var reader = cmd.ExecuteReader())
+                {
+                    Assert.IsTrue(reader.Read());
+                    Assert.AreEqual(1, reader.GetInt32(0));
+                    Assert.AreEqual(2, reader.GetInt32(1));
+                    Assert.IsFalse(reader.Read());
+                }
+            }
+        }
     }
 }