Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(session-keywords): timeout could be a touple #344 #375

Conversation

lucagiove
Copy link
Member

No description provided.

@lucagiove lucagiove linked an issue Jun 6, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13 🎉

Comparison is base (37c49a3) 88.08% compared to head (9d3ef56) 88.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
+ Coverage   88.08%   88.22%   +0.13%     
==========================================
  Files           9        9              
  Lines         445      450       +5     
  Branches      106      108       +2     
==========================================
+ Hits          392      397       +5     
  Misses         51       51              
  Partials        2        2              
Flag Coverage Δ
acceptance 84.00% <50.00%> (-0.72%) ⬇️
unit 60.66% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/RequestsLibrary/SessionKeywords.py 87.41% <100.00%> (+0.45%) ⬆️
src/RequestsLibrary/version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lucagiove lucagiove merged commit e4291b7 into master Jun 6, 2023
@lucagiove lucagiove deleted the 344-inaccurate-timeout-kwarg-description-or-incorrect-handing-of-it branch June 6, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate timeout kwarg description or incorrect handing of it
1 participant